From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: David Miller <davem@davemloft.net>,
Stefano Brivio <stefano.brivio@polimi.it>,
Kalle Valo <kvalo@codeaurora.org>,
Brett Rudley <brudley@broadcom.com>,
Arend van Spriel <arend@broadcom.com>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
Hante Meuleman <meuleman@broadcom.com>,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
brcm80211-dev-list <brcm80211-dev-list@broadcom.com>
Subject: [PATCH net-next] wireless: Use bool function returns of true/false instead of 1/0
Date: Sun, 29 Mar 2015 18:49:01 -0700 [thread overview]
Message-ID: <1427680141.2715.60.camel@perches.com> (raw)
In-Reply-To: <5518AAFD.1050202@lwfinger.net>
On Sun, 2015-03-29 at 20:46 -0500, Larry Finger wrote:
> On 03/29/2015 08:29 PM, Joe Perches wrote:
> > Use bool constants as the return values instead of 1 and 0.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> >> To be honest I'd might rather get bunches of these, there has to be a ton
> >> of them, than a slow trickle of one every few weeks/days.
> >
> > There aren't too many here either...
> >
> > drivers/net/wireless/b43/dma.c | 12 ++++++------
> > drivers/net/wireless/b43legacy/dma.c | 6 +++---
> > drivers/net/wireless/b43legacy/rfkill.c | 8 ++++----
> > drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c | 2 +-
> > drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.c | 2 +-
> > drivers/net/wireless/iwlwifi/iwl-config.h | 4 ++--
> > 6 files changed, 17 insertions(+), 17 deletions(-)
>
> Please split these into separate patches for each driver. That way it will be
> possible to search 'git log' for the contributions to each driver. Otherwise,
> the patches are OK.
It's still possible.
git log <directory> shows the individual patches.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: David Miller <davem@davemloft.net>,
Stefano Brivio <stefano.brivio@polimi.it>,
Kalle Valo <kvalo@codeaurora.org>,
Brett Rudley <brudley@broadcom.com>,
Arend van Spriel <arend@broadcom.com>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
Hante Meuleman <meuleman@broadcom.com>,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
brcm80211-dev-list <brcm80211-dev-list@broadcom.com>
Subject: Re: [PATCH net-next] wireless: Use bool function returns of true/false instead of 1/0
Date: Sun, 29 Mar 2015 18:49:01 -0700 [thread overview]
Message-ID: <1427680141.2715.60.camel@perches.com> (raw)
In-Reply-To: <5518AAFD.1050202@lwfinger.net>
On Sun, 2015-03-29 at 20:46 -0500, Larry Finger wrote:
> On 03/29/2015 08:29 PM, Joe Perches wrote:
> > Use bool constants as the return values instead of 1 and 0.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> >> To be honest I'd might rather get bunches of these, there has to be a ton
> >> of them, than a slow trickle of one every few weeks/days.
> >
> > There aren't too many here either...
> >
> > drivers/net/wireless/b43/dma.c | 12 ++++++------
> > drivers/net/wireless/b43legacy/dma.c | 6 +++---
> > drivers/net/wireless/b43legacy/rfkill.c | 8 ++++----
> > drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c | 2 +-
> > drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.c | 2 +-
> > drivers/net/wireless/iwlwifi/iwl-config.h | 4 ++--
> > 6 files changed, 17 insertions(+), 17 deletions(-)
>
> Please split these into separate patches for each driver. That way it will be
> possible to search 'git log' for the contributions to each driver. Otherwise,
> the patches are OK.
It's still possible.
git log <directory> shows the individual patches.
next prev parent reply other threads:[~2015-03-30 1:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201503260524.AdqSbov9%fengguang.wu@intel.com>
2015-03-25 21:55 ` [PATCH] cxgb4: fix boolreturn.cocci warnings kbuild test robot
2015-03-25 22:14 ` Joe Perches
2015-03-29 19:16 ` David Miller
2015-03-30 1:25 ` [PATCH net-next] ethernet: Use bool function returns of true/false instead of 1/0 Joe Perches
2015-03-30 1:25 ` Joe Perches
2015-03-30 1:29 ` [PATCH net-next] wireless: " Joe Perches
2015-03-30 1:46 ` Larry Finger
2015-03-30 1:46 ` Larry Finger
2015-03-30 1:49 ` Joe Perches [this message]
2015-03-30 1:49 ` Joe Perches
2015-04-07 17:11 ` [net-next] wireless: Use bool function returns of true/false insteadof 1/0 Kalle Valo
2015-04-07 17:11 ` Kalle Valo
2015-03-30 20:28 ` [PATCH net-next] ethernet: Use bool function returns of true/false instead of 1/0 Jeff Kirsher
2015-03-30 20:28 ` Jeff Kirsher
2015-03-31 11:10 ` Michal Simek
2015-03-31 11:10 ` Michal Simek
2015-03-31 19:49 ` Joe Perches
2015-03-31 18:10 ` David Miller
2015-03-31 18:10 ` David Miller
2015-03-31 18:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427680141.2715.60.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=arend@broadcom.com \
--cc=b43-dev@lists.infradead.org \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=frankyl@broadcom.com \
--cc=ilw@linux.intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.