From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] sata_dwc_460ex: indent an if statement
Date: Mon, 30 Mar 2015 10:59:24 +0000 [thread overview]
Message-ID: <1427713164.14897.442.camel@linux.intel.com> (raw)
In-Reply-To: <20150330103025.GA27144@mwanda>
On Mon, 2015-03-30 at 13:30 +0300, Dan Carpenter wrote:
> We shuffled some code around in 8b3444852a2b ('sata_dwc_460ex: move to
> generic DMA driver') an accidentally deleted a tab character here. It
> causes a Smatch warning "if statement not indented".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
> index 5ab4849..9020349 100644
> --- a/drivers/ata/sata_dwc_460ex.c
> +++ b/drivers/ata/sata_dwc_460ex.c
> @@ -295,7 +295,7 @@ static void dma_dwc_xfer_done(void *hsdev_instance)
> }
>
> if ((hsdevp->dma_interrupt_count % 2) = 0)
> - sata_dwc_dma_xfer_complete(ap, 1);
> + sata_dwc_dma_xfer_complete(ap, 1);
>
> spin_unlock_irqrestore(&host->lock, flags);
> }
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] sata_dwc_460ex: indent an if statement
Date: Mon, 30 Mar 2015 13:59:24 +0300 [thread overview]
Message-ID: <1427713164.14897.442.camel@linux.intel.com> (raw)
In-Reply-To: <20150330103025.GA27144@mwanda>
On Mon, 2015-03-30 at 13:30 +0300, Dan Carpenter wrote:
> We shuffled some code around in 8b3444852a2b ('sata_dwc_460ex: move to
> generic DMA driver') an accidentally deleted a tab character here. It
> causes a Smatch warning "if statement not indented".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
> index 5ab4849..9020349 100644
> --- a/drivers/ata/sata_dwc_460ex.c
> +++ b/drivers/ata/sata_dwc_460ex.c
> @@ -295,7 +295,7 @@ static void dma_dwc_xfer_done(void *hsdev_instance)
> }
>
> if ((hsdevp->dma_interrupt_count % 2) == 0)
> - sata_dwc_dma_xfer_complete(ap, 1);
> + sata_dwc_dma_xfer_complete(ap, 1);
>
> spin_unlock_irqrestore(&host->lock, flags);
> }
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2015-03-30 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 10:30 [patch] sata_dwc_460ex: indent an if statement Dan Carpenter
2015-03-30 10:30 ` Dan Carpenter
2015-03-30 10:59 ` Andy Shevchenko [this message]
2015-03-30 10:59 ` Andy Shevchenko
2015-03-30 17:17 ` Tejun Heo
2015-03-30 17:17 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427713164.14897.442.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.