Re: [OSSTEST Nested PATCH v7 5/6] Add test job for nest test case

[Ian Campbell <ian.campbell@citrix.com>]

On Thu, 2015-04-02 at 08:16 +0000, Pang, LongtaoX wrote:
> 
> 
> > -----Original Message-----
> > From: Ian Campbell [mailto:ian.campbell@citrix.com]
> > Sent: Tuesday, March 31, 2015 10:23 PM
> > To: Pang, LongtaoX
> > Cc: xen-devel@lists.xen.org; Ian.Jackson@eu.citrix.com; wei.liu2@citrix.com;
> > Hu, Robert
> > Subject: Re: [OSSTEST Nested PATCH v7 5/6] Add test job for nest test case
> > 
> > On Fri, 2015-03-27 at 19:06 -0400, longtao.pang wrote:
> > > Changes in v7:
> > > diff --git a/make-flight b/make-flight index 8ac3a87..b8f266f 100755
> > > --- a/make-flight
> > > +++ b/make-flight
> > > @@ -204,6 +204,26 @@ do_hvm_win7_x64_tests () {
> > >              all_hostflags=$most_hostflags,hvm  }
> > >
> > > +do_hvm_debian_nested_tests () {
> > > +  if [ $xenarch != amd64 ]; then
> > > +    return
> > > +  fi
> > > +  if [ $dom0arch != amd64 ]; then
> > > +    return
> > > +  fi
> > 
> > You can do these on a line each, or even combine into one test. i.e.
> > 
> >     if [ $xenarch != amd64 -o $dom0arch != amd64 ]; then return; fi
> > 
> I'm sorry I find that the 'if' condition is not appropriate in v7 patch, it should be 
> if [ $xenarch != amd64 -a $dom0arch != amd64 ]; then return; fi

Yes, I think you are right.

> > > +
> > > +  job_create_test test-$xenarch$kern-$dom0arch-nested test-nested xl \
> > > +			$xenarch $dom0arch \
> > > +            nested_image=$NESTED_OS_IMAGE \
> > > +            nested2_image=$NESTED_OS_IMAGE \
> > 
> > I think for clarity you should use something like nestedl1 and nestedl2 for the
> > runvar names.
> > 

> 'nested' and 'nested2' are guest name of L1 and L2 guest VM. Since
> "$specimage" is accessed from "$r{"$gho->{Guest}_image"}" which
> defined in the function of ' target_put_guest_image'. So, maybe
> 'nested' and 'nested2' are available here, I think. 

My point was you should use the clearer names throughout, from point of
definition onwards and in the sg-run-job spec for the recipe too.

Ian.