Re: [OSSTEST Nested PATCH v7 2/6] Edit some testsupport APIs for nested test

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2015-04-01 at 05:56 +0000, Pang, LongtaoX wrote:
> 
> 
> > -----Original Message-----
> > From: Ian Campbell [mailto:ian.campbell@citrix.com]
> > Sent: Tuesday, March 31, 2015 9:50 PM
> > To: Pang, LongtaoX
> > Cc: xen-devel@lists.xen.org; Ian.Jackson@eu.citrix.com; wei.liu2@citrix.com;
> > Hu, Robert
> > Subject: Re: [OSSTEST Nested PATCH v7 2/6] Edit some testsupport APIs for
> > nested test
> > 
> > On Fri, 2015-03-27 at 19:06 -0400, longtao.pang wrote:
> > > 1. Designate vif model to 'e1000' by make-flight.
> > 
> > Strictly you could s/to 'e1000'// here since the make-flight changes are
> > elsewhere and that would better describe the generic change.
> > 
> Do you mean that I should change the description from "Designate vif
> model to 'e1000' by make-flight" to "Designate vif model by
> make-flight"?

Yes, or even better "Add runvar to allow override of default VIF model".

> > > 2. In L2 installation context, its host (L1) IP address is not queried
> > > from DNS, but after running "ts-nested-setup + host + nested", L1 IP
> > > is stored in runvar.
> > >
> > > Signed-off-by: longtao.pang <longtaox.pang@intel.com>
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
>