From: Dario Faggioli <dario.faggioli@citrix.com>
To: "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Julien Grall <julien.grall@citrix.com>,
"lars.kurth@xen.org" <lars.kurth@xen.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"lindaj@jma3.com" <lindaj@jma3.com>
Subject: Re: [PATCH] tools/libxl new bitmap functions
Date: Fri, 3 Apr 2015 14:37:06 +0000 [thread overview]
Message-ID: <1428071825.7917.26.camel@citrix.com> (raw)
In-Reply-To: <20150402193432.GJ3131@x230.dumpdata.com>
[-- Attachment #1.1: Type: text/plain, Size: 601 bytes --]
On Thu, 2015-04-02 at 15:34 -0400, Konrad Rzeszutek Wilk wrote:
> On Thu, Apr 02, 2015 at 11:38:16AM -0600, Linda Jacobson wrote:
> > --- a/tools/libxl/libxl_utils.c
> > +++ b/tools/libxl/libxl_utils.c
> > + goto out;
> > + }
> > +
> > + for (int bit = 0; bit < (size * 8); bit++)
>
> Please move the 'int bit' to the start of the function.
>
Or, even better, use libxl_for_each_bit, defined in libxl_utils.h. :-)
(I wanted to say this in my previous mail, while commenting about the
name of the functions and about the long lines, but forgot. :-D)
Regards,
Dario
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-04-03 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 17:38 [PATCH] tools/libxl new bitmap functions Linda Jacobson
2015-04-02 19:34 ` Konrad Rzeszutek Wilk
2015-04-03 14:37 ` Dario Faggioli [this message]
2015-04-07 15:45 ` Linda
2015-04-07 15:51 ` Julien Grall
2015-04-03 9:25 ` Dario Faggioli
2015-04-03 13:48 ` Linda
2015-04-03 14:34 ` Dario Faggioli
2015-04-07 10:54 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428071825.7917.26.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=julien.grall@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=lars.kurth@xen.org \
--cc=lindaj@jma3.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.