From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Abel Vesa <abelvesa@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/core: Remove wakeup_gran with single call calc_delta_fair
Date: Tue, 07 Apr 2015 18:55:21 +0200 [thread overview]
Message-ID: <1428425721.3160.5.camel@gmail.com> (raw)
In-Reply-To: <CAEZQSsdWaFKf2zETh3NOQJqjedh=xqZqiqbWpff_wuBbz7R0Mw@mail.gmail.com>
On Tue, 2015-04-07 at 16:37 +0300, Abel Vesa wrote:
> On Tue, Apr 7, 2015 at 1:30 PM, Peter Zijlstra <peterz@infradead.org
> > wrote:
> > On Mon, Apr 06, 2015 at 09:43:43PM +0300, Abel Vesa wrote:
> > > This patch removes function wakeup_gran and its call by calling
> > > directly
> > > calc_delta_fair function with sysctl_sched_wakeup_granularity
> > > and se as arguments.
> >
> > But why?
>
> I was thinking that maybe reducing another function call would be a
> better idea.
> I don't see what's the point of calling a 'wakeup_gran' just to
> declare 'gran' as local variable and then
> call calc_delta_fair instead of calling directly calc_delta_fair.
> Plus, I think it seems more
> readable to me. Of course, I might be wrong.
I expected it be inlined by gcc, but that didn't happen with gcc-4.8.3.
-Mike
next prev parent reply other threads:[~2015-04-07 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 18:43 [PATCH] sched/core: Remove wakeup_gran with single call calc_delta_fair Abel Vesa
2015-04-07 10:30 ` Peter Zijlstra
2015-04-07 13:37 ` Abel Vesa
2015-04-07 16:55 ` Mike Galbraith [this message]
2015-04-07 17:25 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428425721.3160.5.camel@gmail.com \
--to=umgwanakikbuti@gmail.com \
--cc=abelvesa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.