From: Ian Campbell <ian.campbell@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Keir Fraser <keir@xen.org>,
xen-devel <xen-devel@lists.xenproject.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v2 1/4] x86/MSI-X: be more careful during teardown
Date: Tue, 14 Apr 2015 14:47:49 +0100 [thread overview]
Message-ID: <1429019269.15516.55.camel@citrix.com> (raw)
In-Reply-To: <552BA47802000078000715E5@mail.emea.novell.com>
On Mon, 2015-04-13 at 10:11 +0100, Jan Beulich wrote:
> >>> On 02.04.15 at 18:49, <stefano.stabellini@eu.citrix.com> wrote:
> > In any case we should make it clear somewhere who is supposed to write
> > to the command register (and other PCI reigsters) at any given time,
> > otherwise it would be very easy for a new kernel update to break the
> > hypervisor and we wouldn't even know why it happened.
>
> We should, but at this point in time this is going to be rather
> problematic. Such a separation of responsibilities should have been
> done before all the pass-through code got written.
Wasn't Stefano just asking to write down the current semantics, problems
and all?
I think that would be a wonderful idea even if for some parts the
documentation is things like:
* "we don't really know";
* "there are multiple parties X, Y and Z involved and it's a
mess";
* "currently qemu, but really ought to be Xen";
* etc.
I think half the problem with coming up with a plan to move forward is
that exactly where we are now isn't very clear, so having a thing to
refer to there might be helpful above and beyond it being a good idea to
write these things down on principal.
Ian.
next prev parent reply other threads:[~2015-04-14 13:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 16:34 [PATCH v2 0/4] x86/MSI-X: XSA-120 follow-up Jan Beulich
2015-03-25 16:39 ` [PATCH v2 1/4] x86/MSI-X: be more careful during teardown Jan Beulich
2015-03-30 10:05 ` Andrew Cooper
2015-04-02 16:49 ` Stefano Stabellini
2015-04-13 9:11 ` Jan Beulich
2015-04-13 10:50 ` Stefano Stabellini
2015-04-13 11:21 ` Jan Beulich
2015-04-13 12:01 ` Stefano Stabellini
2015-04-13 12:47 ` Jan Beulich
2015-04-13 15:09 ` Stefano Stabellini
2015-04-14 13:47 ` Ian Campbell [this message]
2015-03-25 16:39 ` [PATCH v2 2/4] x86/MSI-X: access MSI-X table only after having enabled MSI-X Jan Beulich
2015-04-10 20:02 ` Konrad Rzeszutek Wilk
2015-04-13 9:05 ` Jan Beulich
2015-04-15 17:41 ` Konrad Rzeszutek Wilk
2015-04-16 7:43 ` Jan Beulich
2015-04-16 18:21 ` Konrad Rzeszutek Wilk
2015-04-17 7:09 ` Jan Beulich
2015-04-17 14:01 ` Jan Beulich
2015-03-25 16:40 ` [PATCH v2 3/4] x86/MSI-X: reduce fiddling with control register during restore Jan Beulich
2015-03-25 16:40 ` [PATCH v2 4/4] x86/MSI-X: cleanup Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429019269.15516.55.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.