All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>
Cc: "stefano.stabellini@citrix.com" <stefano.stabellini@citrix.com>,
	Gareth Stockwell <Gareth.Stockwell@arm.com>,
	"tklengyel@sec.in.tum.de" <tklengyel@sec.in.tum.de>,
	Razvan Cojocaru <rcojocaru@bitdefender.com>,
	"xen-devel (xen-devel@lists.xen.org)" <xen-devel@lists.xen.org>
Subject: Re: memaccess: skipping mem_access_send_req
Date: Wed, 15 Apr 2015 10:18:23 +0100	[thread overview]
Message-ID: <1429089503.15516.149.camel@citrix.com> (raw)
In-Reply-To: <5527EAD6.6040900@citrix.com>

On Fri, 2015-04-10 at 16:23 +0100, Julien Grall wrote:
> Hi Razvan,
> 
> On 10/04/15 16:11, Razvan Cojocaru wrote:
> > It's not entirely clear to me what you're trying to do, but if I
> > understand it correctly, there's always the third option of simply using
> > the vm_event system as it is now, and when you get an EPT violation
> > event simply use xc_hvm_inject_trap() from userspace to inject the
> > exception.
> 
> xc_hvm_inject_trap is not implemented on ARM.
> 
> Also, looking to the function, most of the traps and arguments are x86
> specific.

If we need similar behaviour then we should probably implement
HVMOP_inject_trap for ARM, though, not invent another interface.

Perhaps the arg struct needs to become per arch. FWIW I'd do that as
      * s/xen_hvm_inject_trap/xen_hvm_inject_trap_x86
      * #define xen_hvm_inject_trap xen_hvm_inject_trap_x86
      * introduce xen_hvm_inject_trap_arm, change #define to #ifdef tree
        picking the correct one.

Ian.

  reply	other threads:[~2015-04-15  9:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10 15:04 memaccess: skipping mem_access_send_req Gareth Stockwell
2015-04-10 15:11 ` Razvan Cojocaru
2015-04-10 15:23   ` Julien Grall
2015-04-15  9:18     ` Ian Campbell [this message]
2015-04-10 15:28 ` Tamas K Lengyel
2015-04-10 16:03 ` Andrew Cooper
2015-04-17  9:35   ` Gareth Stockwell
2015-04-15  9:26 ` Ian Campbell
2015-04-17  9:35   ` Gareth Stockwell
2015-04-17 10:31     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429089503.15516.149.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Gareth.Stockwell@arm.com \
    --cc=julien.grall@citrix.com \
    --cc=rcojocaru@bitdefender.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=tklengyel@sec.in.tum.de \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.