From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>
Cc: Chen Baozi <baozich@gmail.com>,
julien.grall@linaro.org, xen-devel@lists.xen.org
Subject: Re: [PATCH V2] xen/arm64: Use virtual address when setting up early_printk fixmap
Date: Wed, 15 Apr 2015 15:41:44 +0100 [thread overview]
Message-ID: <1429108904.15516.307.camel@citrix.com> (raw)
In-Reply-To: <552511FA.5080800@citrix.com>
On Wed, 2015-04-08 at 12:33 +0100, Julien Grall wrote:
> Hi Chen,
>
> On 07/04/15 12:24, Chen Baozi wrote:
> > We have already had the boot pagetable when reaching the point
>
> s/had/added/ ?
I think "switched too" is what was meant and more correct.
> > of early_printk fixmap setup. Thus there is no longer necessary
>
> s/there is/it is/ ?
Yes.
> > to calculate physical address of xen_fixmap.
> >
> > Signed-off-by: Chen Baozi <baozich@gmail.com>
>
> Other than the possible typoes above:
>
> Reviewed-by: Julien Grall <julien.grall@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
If it is confirmed that I got the correct meaning in the first one I can
fix both on commit.
Ian.
next prev parent reply other threads:[~2015-04-15 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 11:24 [PATCH V2] xen/arm64: Use virtual address when setting up early_printk fixmap Chen Baozi
2015-04-08 11:33 ` Julien Grall
2015-04-15 14:41 ` Ian Campbell [this message]
2015-04-17 11:39 ` Chen Baozi
2015-05-05 15:36 ` Ian Campbell
2015-05-05 15:06 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429108904.15516.307.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=baozich@gmail.com \
--cc=julien.grall@citrix.com \
--cc=julien.grall@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.