All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: libvir-list@redhat.com, andrew.cooper3@citrix.com,
	xen-devel@lists.xensource.com,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [libvirt] [PATCH 0/2] Re: libvirtd live-locking on CTX_LOCK when doing 'virsh <domid> save /tmp/blah' with guest corrupting memory (on purpose).
Date: Fri, 17 Apr 2015 09:58:33 +0100	[thread overview]
Message-ID: <1429261113.25195.204.camel@citrix.com> (raw)
In-Reply-To: <21807.61130.841852.546321@mariner.uk.xensource.com>

On Thu, 2015-04-16 at 18:18 +0100, Ian Jackson wrote:
> Jim Fehlig writes ("Re: [PATCH 0/2] Re: libvirtd live-locking on CTX_LOCK when doing 'virsh <domid> save /tmp/blah' with guest corrupting memory (on purpose)."):
> > On 04/14/2015 11:31 AM, Ian Jackson wrote:
> > > I have produced what I think are two patches that will fix this.  I
> > > have compiled them but I haven't tested them.  Konrad, are you able to
> > > check whether they fix your bug ?
> > 
> > I too saw this bug just before Konrad's report, but the patches don't seem to 
> > help.  Running a script that continually saves and restores domains will 
> > eventually lock libvirtd with essentially the same traces reported by Konrad
> 
> I'm a total idiot.  I do the recheck but I don't pay any attention to
> the result.

Your second patch was updating revents which was used in the next if,
what have I missed?

> I will send an updated approach which does this centrally.

Ack, that's probably best anyhow.

      reply	other threads:[~2015-04-17  8:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 14:47 [libvirt] libvirtd live-locking on CTX_LOCK when doing 'virsh <domid> save /tmp/blah' with guest corrupting memory (on purpose) Konrad Rzeszutek Wilk
2015-04-08 15:45 ` Andrew Cooper
2015-04-10 15:44   ` Konrad Rzeszutek Wilk
2015-04-10 16:05     ` Andrew Cooper
2015-04-14 17:31 ` [libvirt] [PATCH 0/2] " Ian Jackson
2015-04-14 17:31   ` [PATCH 1/2] libxl: fd events: Document spurious callbacks, break out libxl__ev_fd_recheck Ian Jackson
2015-04-14 17:31     ` [PATCH 2/2] libxl: save helper: Recheck fd events Ian Jackson
2015-04-16 13:02       ` Ian Campbell
2015-04-16 14:23         ` Ian Jackson
2015-04-16 13:01     ` [PATCH 1/2] libxl: fd events: Document spurious callbacks, break out libxl__ev_fd_recheck Ian Campbell
2015-04-16 16:44   ` [libvirt] [PATCH 0/2] Re: libvirtd live-locking on CTX_LOCK when doing 'virsh <domid> save /tmp/blah' with guest corrupting memory (on purpose) Jim Fehlig
2015-04-16 17:18     ` Ian Jackson
2015-04-17  8:58       ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429261113.25195.204.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=libvir-list@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.