All of lore.kernel.org
 help / color / mirror / Atom feed
* [OSSTEST PATCH] target_cmd_build: Delete build-ok-stamp before starting
@ 2015-04-21 16:40 Ian Jackson
  2015-04-22  9:38 ` Ian Campbell
  0 siblings, 1 reply; 2+ messages in thread
From: Ian Jackson @ 2015-04-21 16:40 UTC (permalink / raw)
  To: xen-devel; +Cc: Ian Jackson, Ian Campbell

Many of the callers of target_cmd_build use a build-ok-stamp idiom to
detect failed builds.  This idiom does not work if the stamp file
exists already, so delete it.

In the future we may move more of the test build-ok-stamp, echo ok,
into TestSupport, but this will do for now.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 Osstest/TestSupport.pm |    1 +
 1 file changed, 1 insertion(+)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index b50ad0a..3ff70a5 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -593,6 +593,7 @@ END
 END
         exec </dev/null
         cd $builddir
+        rm -f build-ok-stamp
 END
 }
 
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [OSSTEST PATCH] target_cmd_build: Delete build-ok-stamp before starting
  2015-04-21 16:40 [OSSTEST PATCH] target_cmd_build: Delete build-ok-stamp before starting Ian Jackson
@ 2015-04-22  9:38 ` Ian Campbell
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2015-04-22  9:38 UTC (permalink / raw)
  To: Ian Jackson; +Cc: xen-devel

On Tue, 2015-04-21 at 17:40 +0100, Ian Jackson wrote:
> Many of the callers of target_cmd_build use a build-ok-stamp idiom to
> detect failed builds.  This idiom does not work if the stamp file
> exists already, so delete it.
> 
> In the future we may move more of the test build-ok-stamp, echo ok,
> into TestSupport, but this will do for now.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-22  9:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-21 16:40 [OSSTEST PATCH] target_cmd_build: Delete build-ok-stamp before starting Ian Jackson
2015-04-22  9:38 ` Ian Campbell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.