Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2015-04-22 at 08:25 +0000, Pang, LongtaoX wrote:
> 
> 
> > -----Original Message-----
> > From: Ian Campbell [mailto:ian.campbell@citrix.com]
> > Sent: Tuesday, April 21, 2015 10:44 PM
> > To: Ian Jackson
> > Cc: Pang, LongtaoX; xen-devel@lists.xen.org; wei.liu2@citrix.com; Hu, Robert
> > Subject: Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for
> > nested test
> > 
> > On Tue, 2015-04-21 at 15:30 +0100, Ian Jackson wrote:
> > > Ian Campbell writes ("Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in
> > TestSupport.pm for nested test"):
> > > > On Tue, 2015-04-21 at 14:28 +0100, Ian Jackson wrote:
> > > > > I'm only objecting to the involvement of the host property machinery.
> > > >
> > > > I'm afraid I'm not 100% sure I understand, but do you just mean that
> > > > longtao should assign to $ho->{Ip} directly within selecthost instead of
> > > > using $setprop to set the IpAddr hostprop and therefore indirectly
> > > > ->{Ip}?
> > >
> > > Yes.
> > >
> > > > IOW the existing code in selecthost which looks up the IpAddr host prop
> > > > into $ho->{IpStatic} and then into $ho->{Ip} should prefer the runvar to
> > > > the host db if it is set?
> > >
> > > Yes.
> > 
> > Good. Longtao, do you understand what is needed here?
> > 
> I think I get it, use ${ident} rather than ${name} and assign L1's IP to $ho->{Ip} directly.
> The code will be like:
> if ( $r{"${ident}_ip"} ) {
>     $ho->{Ip}= $r{"${ident}_ip"};
> }

It will, I think, need to be integrated with the existing assignment to
$ho->{Ip} in select host, so something like:

        if ( $r{"${ident}_ip"} ) {
            $ho->{Ip}= $r{"${ident}_ip"};
        } else {
            $ho->{Ip}= $ho->{IpStatic};
        }
        
or perhaps:

        $ho->{Ip} = $r{"${ident}_ip"} ? $r{"${ident}_ip"} : $ho->{IpStatic};

Ian.