Re: [OSSTEST Nested PATCH v8 7/7] Add test job for nest test case

[Ian Campbell <ian.campbell@citrix.com>]

On Mon, 2015-04-13 at 17:19 -0400, longtao.pang wrote:
> 1. This patch adds creation of the nested test job, when job creation
> procedure is invoked.
> 2. Set nested L1's vif model as e1000 by make-flight.
> 
> Signed-off-by: longtao.pang <longtaox.pang@intel.com>
> ---
> Changes in v8:
> 1. Use 'nestedl1' and 'nestedl2' as L1 and L2's clearer name in nested
> test job.
> 2. Setting Debian_ISO as 'debian-7.2.0-amd64-CD-1.iso' in make-flight.
> ---
>  make-flight |   20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/make-flight b/make-flight
> index cc8ecdb..40ca808 100755
> --- a/make-flight
> +++ b/make-flight
> @@ -204,6 +204,25 @@ do_hvm_win7_x64_tests () {
>              all_hostflags=$most_hostflags,hvm
>  }
>  
> +do_hvm_debian_nested_tests () {
> +  if [ $xenarch != amd64 -a $dom0arch != amd64 ]; then
> +    return
> +  fi
> +
> +  job_create_test test-$xenarch$kern-$dom0arch-nested test-nested xl \
> +                        $xenarch $dom0arch \
> +            nestedl1_image=debian-7.2.0-amd64-CD-1.iso \
> +            nestedl2_image=debian-7.2.0-amd64-CD-1.iso \
> +            bios=seabios \
> +            kernbuildjob=build-amd64-pvops \
> +            kernkind=pvops \
> +            nestedl1_vifmodel='e1000' \
> +            nested_disk='15000' \

Should be nestedl1_disk I think.

It would be best to group nestedl1_* and nestedl2_* together in the
list, rather than having image up above. i.e.

            nestedl1_vifmodel='e1000' \
            nestedl1_memory='3072' \
            nestedl1_disk='15000' \
            nestedl1_image='....' \
            nestedl1_foo='bar' \
            nestedl2_disk='20000' \
            nestedl2_foo='baz' \
etc.

Ian.