* [PATCH 1/2] mmc: sdhci_f_sdh30: Staticize local functions
@ 2015-04-24 7:00 Axel Lin
2015-04-24 7:02 ` [PATCH 2/2] mmc: sdhci_f_sdh30: Fix the size passed to sdhci_alloc_host Axel Lin
2015-05-05 8:34 ` [PATCH 1/2] mmc: sdhci_f_sdh30: Staticize local functions Ulf Hansson
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2015-04-24 7:00 UTC (permalink / raw)
To: Ulf Hansson; +Cc: Andy Green, Vincent Yang, linux-mmc@vger.kernel.org
Make local functions static.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/mmc/host/sdhci_f_sdh30.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/sdhci_f_sdh30.c b/drivers/mmc/host/sdhci_f_sdh30.c
index 2fe8b91..5397e27 100644
--- a/drivers/mmc/host/sdhci_f_sdh30.c
+++ b/drivers/mmc/host/sdhci_f_sdh30.c
@@ -49,7 +49,7 @@ struct f_sdhost_priv {
struct device *dev;
};
-void sdhci_f_sdh30_soft_voltage_switch(struct sdhci_host *host)
+static void sdhci_f_sdh30_soft_voltage_switch(struct sdhci_host *host)
{
struct f_sdhost_priv *priv = sdhci_priv(host);
u32 ctrl = 0;
@@ -77,12 +77,12 @@ void sdhci_f_sdh30_soft_voltage_switch(struct sdhci_host *host)
sdhci_writel(host, ctrl, F_SDH30_TUNING_SETTING);
}
-unsigned int sdhci_f_sdh30_get_min_clock(struct sdhci_host *host)
+static unsigned int sdhci_f_sdh30_get_min_clock(struct sdhci_host *host)
{
return F_SDH30_MIN_CLOCK;
}
-void sdhci_f_sdh30_reset(struct sdhci_host *host, u8 mask)
+static void sdhci_f_sdh30_reset(struct sdhci_host *host, u8 mask)
{
if (sdhci_readw(host, SDHCI_CLOCK_CONTROL) == 0)
sdhci_writew(host, 0xBC01, SDHCI_CLOCK_CONTROL);
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] mmc: sdhci_f_sdh30: Fix the size passed to sdhci_alloc_host
2015-04-24 7:00 [PATCH 1/2] mmc: sdhci_f_sdh30: Staticize local functions Axel Lin
@ 2015-04-24 7:02 ` Axel Lin
2015-05-05 8:34 ` Ulf Hansson
2015-05-05 8:34 ` [PATCH 1/2] mmc: sdhci_f_sdh30: Staticize local functions Ulf Hansson
1 sibling, 1 reply; 4+ messages in thread
From: Axel Lin @ 2015-04-24 7:02 UTC (permalink / raw)
To: Ulf Hansson; +Cc: Andy Green, Vincent Yang, linux-mmc@vger.kernel.org
sdhci_alloc_host() takes priv_size rather than
sizeof(struct sdhci_host) + priv_size.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/mmc/host/sdhci_f_sdh30.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci_f_sdh30.c b/drivers/mmc/host/sdhci_f_sdh30.c
index 5397e27..983b8b3 100644
--- a/drivers/mmc/host/sdhci_f_sdh30.c
+++ b/drivers/mmc/host/sdhci_f_sdh30.c
@@ -114,8 +114,7 @@ static int sdhci_f_sdh30_probe(struct platform_device *pdev)
return irq;
}
- host = sdhci_alloc_host(dev, sizeof(struct sdhci_host) +
- sizeof(struct f_sdhost_priv));
+ host = sdhci_alloc_host(dev, sizeof(struct f_sdhost_priv));
if (IS_ERR(host))
return PTR_ERR(host);
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] mmc: sdhci_f_sdh30: Staticize local functions
2015-04-24 7:00 [PATCH 1/2] mmc: sdhci_f_sdh30: Staticize local functions Axel Lin
2015-04-24 7:02 ` [PATCH 2/2] mmc: sdhci_f_sdh30: Fix the size passed to sdhci_alloc_host Axel Lin
@ 2015-05-05 8:34 ` Ulf Hansson
1 sibling, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2015-05-05 8:34 UTC (permalink / raw)
To: Axel Lin; +Cc: Andy Green, Vincent Yang, linux-mmc@vger.kernel.org
On 24 April 2015 at 09:00, Axel Lin <axel.lin@ingics.com> wrote:
> Make local functions static.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Thanks, applied!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci_f_sdh30.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci_f_sdh30.c b/drivers/mmc/host/sdhci_f_sdh30.c
> index 2fe8b91..5397e27 100644
> --- a/drivers/mmc/host/sdhci_f_sdh30.c
> +++ b/drivers/mmc/host/sdhci_f_sdh30.c
> @@ -49,7 +49,7 @@ struct f_sdhost_priv {
> struct device *dev;
> };
>
> -void sdhci_f_sdh30_soft_voltage_switch(struct sdhci_host *host)
> +static void sdhci_f_sdh30_soft_voltage_switch(struct sdhci_host *host)
> {
> struct f_sdhost_priv *priv = sdhci_priv(host);
> u32 ctrl = 0;
> @@ -77,12 +77,12 @@ void sdhci_f_sdh30_soft_voltage_switch(struct sdhci_host *host)
> sdhci_writel(host, ctrl, F_SDH30_TUNING_SETTING);
> }
>
> -unsigned int sdhci_f_sdh30_get_min_clock(struct sdhci_host *host)
> +static unsigned int sdhci_f_sdh30_get_min_clock(struct sdhci_host *host)
> {
> return F_SDH30_MIN_CLOCK;
> }
>
> -void sdhci_f_sdh30_reset(struct sdhci_host *host, u8 mask)
> +static void sdhci_f_sdh30_reset(struct sdhci_host *host, u8 mask)
> {
> if (sdhci_readw(host, SDHCI_CLOCK_CONTROL) == 0)
> sdhci_writew(host, 0xBC01, SDHCI_CLOCK_CONTROL);
> --
> 2.1.0
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] mmc: sdhci_f_sdh30: Fix the size passed to sdhci_alloc_host
2015-04-24 7:02 ` [PATCH 2/2] mmc: sdhci_f_sdh30: Fix the size passed to sdhci_alloc_host Axel Lin
@ 2015-05-05 8:34 ` Ulf Hansson
0 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2015-05-05 8:34 UTC (permalink / raw)
To: Axel Lin; +Cc: Andy Green, Vincent Yang, linux-mmc@vger.kernel.org
On 24 April 2015 at 09:02, Axel Lin <axel.lin@ingics.com> wrote:
> sdhci_alloc_host() takes priv_size rather than
> sizeof(struct sdhci_host) + priv_size.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Thanks, applied!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci_f_sdh30.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci_f_sdh30.c b/drivers/mmc/host/sdhci_f_sdh30.c
> index 5397e27..983b8b3 100644
> --- a/drivers/mmc/host/sdhci_f_sdh30.c
> +++ b/drivers/mmc/host/sdhci_f_sdh30.c
> @@ -114,8 +114,7 @@ static int sdhci_f_sdh30_probe(struct platform_device *pdev)
> return irq;
> }
>
> - host = sdhci_alloc_host(dev, sizeof(struct sdhci_host) +
> - sizeof(struct f_sdhost_priv));
> + host = sdhci_alloc_host(dev, sizeof(struct f_sdhost_priv));
> if (IS_ERR(host))
> return PTR_ERR(host);
>
> --
> 2.1.0
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-05 8:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-24 7:00 [PATCH 1/2] mmc: sdhci_f_sdh30: Staticize local functions Axel Lin
2015-04-24 7:02 ` [PATCH 2/2] mmc: sdhci_f_sdh30: Fix the size passed to sdhci_alloc_host Axel Lin
2015-05-05 8:34 ` Ulf Hansson
2015-05-05 8:34 ` [PATCH 1/2] mmc: sdhci_f_sdh30: Staticize local functions Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.