From: Matthias Brugger <matthias.bgg@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>, Frank Wunderlich <linux@fw-web.de>
Cc: devicetree@vger.kernel.org, Wenbin Mei <wenbin.mei@mediatek.com>,
Sam Shih <Sam.Shih@mediatek.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chaotian Jing <chaotian.jing@mediatek.com>
Subject: Re: [PATCH v5 0/6] Add mmc-support for mt7986
Date: Tue, 8 Nov 2022 19:34:06 +0100 [thread overview]
Message-ID: <142fe940-6fcf-4eaa-2cb6-94df541723c3@gmail.com> (raw)
In-Reply-To: <CAPDyKFriLmsSsy5LfiJJH-s7uQMD1AycE7R4NtN1_Td3XocyOQ@mail.gmail.com>
On 26/10/2022 13:25, Ulf Hansson wrote:
> On Tue, 25 Oct 2022 at 15:29, Frank Wunderlich <linux@fw-web.de> wrote:
>>
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> I've noticed the mtk-sd binding needs a bit more work get into a more
>> clean state.
>>
>> There are 2 properties missing that maybe need to be added later or
>> dropped from devicetrees:
>> drv-type (which is used in mt8183-kukui.dtsi and set to <2>)
>> and
>> r_smpl (used in mt7622-rfb1.dts and mt7622-bananapi-bpi-r64.dts, both
>> times set to <1>)
>>
>> i don't know their function and boundaries and i do not find them in
>> driver. I guess they are added by accident, so i removing them in the
>> patches 5+6.
>>
>> v2:
>> - add compatible based binding
>> v3:
>> - solve "not" statement in binding and reorder if statements,drop mt8183
>> - added patches removing invalid properties (not in driver)
>> v4:
>> - squashed part 1 (compatible) and 3 (SoC specific clock config)
>> - new mt7986 clock bindings based on info from mtk
>> - re-add mt8183 reg boundary
>> v5:
>> - add fixes-tags to Patches 4+5 and reviewed-by to 6
>> - drop quotes from mt7986 clock-names from patch 2
>>
>> Frank Wunderlich (3):
>> arm64: dts: mediatek: mt2712e: swap last 2 clocks to match binding
>> arm64: dts: mt8183: drop drv-type from mmc-node
>> arm64: dts: mt7622: drop r_smpl property from mmc node
>>
>> Nícolas F. R. A. Prado (1):
>> dt-bindings: mmc: mtk-sd: Set clocks based on compatible
>>
>> Sam Shih (2):
>> dt-bindings: mmc: Add support for Mediatek MT7986
>> mmc: mediatek: add support for MT7986 SoC
>>
>> .../devicetree/bindings/mmc/mtk-sd.yaml | 149 ++++++++++++++----
>> arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 6 +-
>> .../dts/mediatek/mt7622-bananapi-bpi-r64.dts | 1 -
>> arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 1 -
>> .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 -
>> drivers/mmc/host/mtk-sd.c | 14 ++
>> 6 files changed, 136 insertions(+), 36 deletions(-)
>
> I have dropped the earlier two patches I have applied for MT7986 and
> applied patch1, 2 and 6 from this series instead, thanks!
>
3, 4, 5 applied now thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>, Frank Wunderlich <linux@fw-web.de>
Cc: linux-mediatek@lists.infradead.org,
Frank Wunderlich <frank-w@public-files.de>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Wenbin Mei <wenbin.mei@mediatek.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Sam Shih <Sam.Shih@mediatek.com>
Subject: Re: [PATCH v5 0/6] Add mmc-support for mt7986
Date: Tue, 8 Nov 2022 19:34:06 +0100 [thread overview]
Message-ID: <142fe940-6fcf-4eaa-2cb6-94df541723c3@gmail.com> (raw)
In-Reply-To: <CAPDyKFriLmsSsy5LfiJJH-s7uQMD1AycE7R4NtN1_Td3XocyOQ@mail.gmail.com>
On 26/10/2022 13:25, Ulf Hansson wrote:
> On Tue, 25 Oct 2022 at 15:29, Frank Wunderlich <linux@fw-web.de> wrote:
>>
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> I've noticed the mtk-sd binding needs a bit more work get into a more
>> clean state.
>>
>> There are 2 properties missing that maybe need to be added later or
>> dropped from devicetrees:
>> drv-type (which is used in mt8183-kukui.dtsi and set to <2>)
>> and
>> r_smpl (used in mt7622-rfb1.dts and mt7622-bananapi-bpi-r64.dts, both
>> times set to <1>)
>>
>> i don't know their function and boundaries and i do not find them in
>> driver. I guess they are added by accident, so i removing them in the
>> patches 5+6.
>>
>> v2:
>> - add compatible based binding
>> v3:
>> - solve "not" statement in binding and reorder if statements,drop mt8183
>> - added patches removing invalid properties (not in driver)
>> v4:
>> - squashed part 1 (compatible) and 3 (SoC specific clock config)
>> - new mt7986 clock bindings based on info from mtk
>> - re-add mt8183 reg boundary
>> v5:
>> - add fixes-tags to Patches 4+5 and reviewed-by to 6
>> - drop quotes from mt7986 clock-names from patch 2
>>
>> Frank Wunderlich (3):
>> arm64: dts: mediatek: mt2712e: swap last 2 clocks to match binding
>> arm64: dts: mt8183: drop drv-type from mmc-node
>> arm64: dts: mt7622: drop r_smpl property from mmc node
>>
>> Nícolas F. R. A. Prado (1):
>> dt-bindings: mmc: mtk-sd: Set clocks based on compatible
>>
>> Sam Shih (2):
>> dt-bindings: mmc: Add support for Mediatek MT7986
>> mmc: mediatek: add support for MT7986 SoC
>>
>> .../devicetree/bindings/mmc/mtk-sd.yaml | 149 ++++++++++++++----
>> arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 6 +-
>> .../dts/mediatek/mt7622-bananapi-bpi-r64.dts | 1 -
>> arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 1 -
>> .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 -
>> drivers/mmc/host/mtk-sd.c | 14 ++
>> 6 files changed, 136 insertions(+), 36 deletions(-)
>
> I have dropped the earlier two patches I have applied for MT7986 and
> applied patch1, 2 and 6 from this series instead, thanks!
>
3, 4, 5 applied now thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>, Frank Wunderlich <linux@fw-web.de>
Cc: linux-mediatek@lists.infradead.org,
Frank Wunderlich <frank-w@public-files.de>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Wenbin Mei <wenbin.mei@mediatek.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Sam Shih <Sam.Shih@mediatek.com>
Subject: Re: [PATCH v5 0/6] Add mmc-support for mt7986
Date: Tue, 8 Nov 2022 19:34:06 +0100 [thread overview]
Message-ID: <142fe940-6fcf-4eaa-2cb6-94df541723c3@gmail.com> (raw)
In-Reply-To: <CAPDyKFriLmsSsy5LfiJJH-s7uQMD1AycE7R4NtN1_Td3XocyOQ@mail.gmail.com>
On 26/10/2022 13:25, Ulf Hansson wrote:
> On Tue, 25 Oct 2022 at 15:29, Frank Wunderlich <linux@fw-web.de> wrote:
>>
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> I've noticed the mtk-sd binding needs a bit more work get into a more
>> clean state.
>>
>> There are 2 properties missing that maybe need to be added later or
>> dropped from devicetrees:
>> drv-type (which is used in mt8183-kukui.dtsi and set to <2>)
>> and
>> r_smpl (used in mt7622-rfb1.dts and mt7622-bananapi-bpi-r64.dts, both
>> times set to <1>)
>>
>> i don't know their function and boundaries and i do not find them in
>> driver. I guess they are added by accident, so i removing them in the
>> patches 5+6.
>>
>> v2:
>> - add compatible based binding
>> v3:
>> - solve "not" statement in binding and reorder if statements,drop mt8183
>> - added patches removing invalid properties (not in driver)
>> v4:
>> - squashed part 1 (compatible) and 3 (SoC specific clock config)
>> - new mt7986 clock bindings based on info from mtk
>> - re-add mt8183 reg boundary
>> v5:
>> - add fixes-tags to Patches 4+5 and reviewed-by to 6
>> - drop quotes from mt7986 clock-names from patch 2
>>
>> Frank Wunderlich (3):
>> arm64: dts: mediatek: mt2712e: swap last 2 clocks to match binding
>> arm64: dts: mt8183: drop drv-type from mmc-node
>> arm64: dts: mt7622: drop r_smpl property from mmc node
>>
>> Nícolas F. R. A. Prado (1):
>> dt-bindings: mmc: mtk-sd: Set clocks based on compatible
>>
>> Sam Shih (2):
>> dt-bindings: mmc: Add support for Mediatek MT7986
>> mmc: mediatek: add support for MT7986 SoC
>>
>> .../devicetree/bindings/mmc/mtk-sd.yaml | 149 ++++++++++++++----
>> arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 6 +-
>> .../dts/mediatek/mt7622-bananapi-bpi-r64.dts | 1 -
>> arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 1 -
>> .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 -
>> drivers/mmc/host/mtk-sd.c | 14 ++
>> 6 files changed, 136 insertions(+), 36 deletions(-)
>
> I have dropped the earlier two patches I have applied for MT7986 and
> applied patch1, 2 and 6 from this series instead, thanks!
>
3, 4, 5 applied now thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-08 18:34 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 13:29 [PATCH v5 0/6] Add mmc-support for mt7986 Frank Wunderlich
2022-10-25 13:29 ` Frank Wunderlich
2022-10-25 13:29 ` Frank Wunderlich
2022-10-25 13:29 ` [PATCH v5 1/6] dt-bindings: mmc: mtk-sd: Set clocks based on compatible Frank Wunderlich
2022-10-25 13:29 ` Frank Wunderlich
2022-10-25 13:29 ` Frank Wunderlich
2022-10-28 9:24 ` AngeloGioacchino Del Regno
2022-10-28 9:24 ` AngeloGioacchino Del Regno
2022-10-25 13:29 ` [PATCH v5 2/6] dt-bindings: mmc: Add support for Mediatek MT7986 Frank Wunderlich
2022-10-25 13:29 ` Frank Wunderlich
2022-10-25 13:29 ` Frank Wunderlich
2022-10-25 13:51 ` Krzysztof Kozlowski
2022-10-25 13:51 ` Krzysztof Kozlowski
2022-10-25 13:51 ` Krzysztof Kozlowski
2022-10-28 9:25 ` AngeloGioacchino Del Regno
2022-10-28 9:25 ` AngeloGioacchino Del Regno
2022-10-25 13:29 ` [PATCH v5 3/6] arm64: dts: mediatek: mt2712e: swap last 2 clocks to match binding Frank Wunderlich
2022-10-25 13:29 ` Frank Wunderlich
2022-10-25 13:29 ` Frank Wunderlich
2022-10-28 9:25 ` AngeloGioacchino Del Regno
2022-10-28 9:25 ` AngeloGioacchino Del Regno
2022-10-25 13:29 ` [PATCH v5 4/6] arm64: dts: mt8183: drop drv-type from mmc-node Frank Wunderlich
2022-10-25 13:29 ` Frank Wunderlich
2022-10-25 13:29 ` Frank Wunderlich
2022-10-27 8:01 ` AngeloGioacchino Del Regno
2022-10-27 8:01 ` AngeloGioacchino Del Regno
2022-10-25 13:29 ` [PATCH v5 5/6] arm64: dts: mt7622: drop r_smpl property from mmc node Frank Wunderlich
2022-10-25 13:29 ` Frank Wunderlich
2022-10-25 13:29 ` Frank Wunderlich
2022-10-27 8:01 ` AngeloGioacchino Del Regno
2022-10-27 8:01 ` AngeloGioacchino Del Regno
2022-10-25 13:29 ` [PATCH v5 6/6] mmc: mediatek: add support for MT7986 SoC Frank Wunderlich
2022-10-25 13:29 ` Frank Wunderlich
2022-10-25 13:29 ` Frank Wunderlich
2022-10-26 11:25 ` [PATCH v5 0/6] Add mmc-support for mt7986 Ulf Hansson
2022-10-26 11:25 ` Ulf Hansson
2022-10-26 11:25 ` Ulf Hansson
2022-11-08 18:34 ` Matthias Brugger [this message]
2022-11-08 18:34 ` Matthias Brugger
2022-11-08 18:34 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=142fe940-6fcf-4eaa-2cb6-94df541723c3@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=Sam.Shih@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@fw-web.de \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wenbin.mei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.