From: contact@paulk.fr (Paul Kocialkowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] arch: arm: Show the serial number from devicetree in cpuinfo
Date: Mon, 27 Apr 2015 10:27:28 +0200 [thread overview]
Message-ID: <1430123248.3081.1.camel@collins> (raw)
In-Reply-To: <1429351135-11842-2-git-send-email-contact@paulk.fr>
Le samedi 18 avril 2015 ? 11:58 +0200, Paul Kocialkowski a ?crit :
> This grabs the serial number shown in cpuinfo from the serial-number devicetree
> property in priority. When booting with ATAGs (and without device-tree), the
> provided number is still shown instead.
Any further comment on this?
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
> arch/arm/include/asm/system_info.h | 1 +
> arch/arm/kernel/setup.c | 27 +++++++++++++++++++++++++--
> 2 files changed, 26 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/system_info.h b/arch/arm/include/asm/system_info.h
> index 720ea03..3860cbd40 100644
> --- a/arch/arm/include/asm/system_info.h
> +++ b/arch/arm/include/asm/system_info.h
> @@ -17,6 +17,7 @@
>
> /* information about the system we're running on */
> extern unsigned int system_rev;
> +extern const char *system_serial;
> extern unsigned int system_serial_low;
> extern unsigned int system_serial_high;
> extern unsigned int mem_fclk_21285;
> diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
> index 1d60beb..349790f 100644
> --- a/arch/arm/kernel/setup.c
> +++ b/arch/arm/kernel/setup.c
> @@ -93,6 +93,9 @@ unsigned int __atags_pointer __initdata;
> unsigned int system_rev;
> EXPORT_SYMBOL(system_rev);
>
> +const char *system_serial;
> +EXPORT_SYMBOL(system_serial);
> +
> unsigned int system_serial_low;
> EXPORT_SYMBOL(system_serial_low);
>
> @@ -821,8 +824,29 @@ arch_initcall(customize_machine);
>
> static int __init init_machine_late(void)
> {
> +#ifdef CONFIG_OF
> + struct device_node *root;
> + int ret;
> +#endif
> +
> if (machine_desc->init_late)
> machine_desc->init_late();
> +
> +#ifdef CONFIG_OF
> + root = of_find_node_by_path("/");
> + if (root) {
> + ret = of_property_read_string(root, "serial-number",
> + &system_serial);
> + if (ret)
> + system_serial = NULL;
> + }
> +#endif
> +
> + if (!system_serial)
> + system_serial = kasprintf(GFP_KERNEL, "%08x%08x",
> + system_serial_high,
> + system_serial_low);
> +
> return 0;
> }
> late_initcall(init_machine_late);
> @@ -1091,8 +1115,7 @@ static int c_show(struct seq_file *m, void *v)
>
> seq_printf(m, "Hardware\t: %s\n", machine_name);
> seq_printf(m, "Revision\t: %04x\n", system_rev);
> - seq_printf(m, "Serial\t\t: %08x%08x\n",
> - system_serial_high, system_serial_low);
> + seq_printf(m, "Serial\t\t: %s\n", system_serial);
>
> return 0;
> }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150427/9c4abe91/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
To: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>,
Hans De Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH v3 2/2] arch: arm: Show the serial number from devicetree in cpuinfo
Date: Mon, 27 Apr 2015 10:27:28 +0200 [thread overview]
Message-ID: <1430123248.3081.1.camel@collins> (raw)
In-Reply-To: <1429351135-11842-2-git-send-email-contact-W9ppeneeCTY@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2576 bytes --]
Le samedi 18 avril 2015 à 11:58 +0200, Paul Kocialkowski a écrit :
> This grabs the serial number shown in cpuinfo from the serial-number devicetree
> property in priority. When booting with ATAGs (and without device-tree), the
> provided number is still shown instead.
Any further comment on this?
> Signed-off-by: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
> ---
> arch/arm/include/asm/system_info.h | 1 +
> arch/arm/kernel/setup.c | 27 +++++++++++++++++++++++++--
> 2 files changed, 26 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/system_info.h b/arch/arm/include/asm/system_info.h
> index 720ea03..3860cbd40 100644
> --- a/arch/arm/include/asm/system_info.h
> +++ b/arch/arm/include/asm/system_info.h
> @@ -17,6 +17,7 @@
>
> /* information about the system we're running on */
> extern unsigned int system_rev;
> +extern const char *system_serial;
> extern unsigned int system_serial_low;
> extern unsigned int system_serial_high;
> extern unsigned int mem_fclk_21285;
> diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
> index 1d60beb..349790f 100644
> --- a/arch/arm/kernel/setup.c
> +++ b/arch/arm/kernel/setup.c
> @@ -93,6 +93,9 @@ unsigned int __atags_pointer __initdata;
> unsigned int system_rev;
> EXPORT_SYMBOL(system_rev);
>
> +const char *system_serial;
> +EXPORT_SYMBOL(system_serial);
> +
> unsigned int system_serial_low;
> EXPORT_SYMBOL(system_serial_low);
>
> @@ -821,8 +824,29 @@ arch_initcall(customize_machine);
>
> static int __init init_machine_late(void)
> {
> +#ifdef CONFIG_OF
> + struct device_node *root;
> + int ret;
> +#endif
> +
> if (machine_desc->init_late)
> machine_desc->init_late();
> +
> +#ifdef CONFIG_OF
> + root = of_find_node_by_path("/");
> + if (root) {
> + ret = of_property_read_string(root, "serial-number",
> + &system_serial);
> + if (ret)
> + system_serial = NULL;
> + }
> +#endif
> +
> + if (!system_serial)
> + system_serial = kasprintf(GFP_KERNEL, "%08x%08x",
> + system_serial_high,
> + system_serial_low);
> +
> return 0;
> }
> late_initcall(init_machine_late);
> @@ -1091,8 +1115,7 @@ static int c_show(struct seq_file *m, void *v)
>
> seq_printf(m, "Hardware\t: %s\n", machine_name);
> seq_printf(m, "Revision\t: %04x\n", system_rev);
> - seq_printf(m, "Serial\t\t: %08x%08x\n",
> - system_serial_high, system_serial_low);
> + seq_printf(m, "Serial\t\t: %s\n", system_serial);
>
> return 0;
> }
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-04-27 8:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 9:58 [PATCH v3 1/2] Documentation: devicetree: root node serial-number property documentation Paul Kocialkowski
2015-04-18 9:58 ` Paul Kocialkowski
2015-04-18 9:58 ` [PATCH v3 2/2] arch: arm: Show the serial number from devicetree in cpuinfo Paul Kocialkowski
2015-04-18 9:58 ` Paul Kocialkowski
2015-04-27 8:27 ` Paul Kocialkowski [this message]
2015-04-27 8:27 ` Paul Kocialkowski
2015-04-27 13:48 ` Rob Herring
2015-04-27 13:48 ` Rob Herring
2015-04-27 14:42 ` Paul Kocialkowski
2015-04-27 14:42 ` Paul Kocialkowski
2015-04-27 15:20 ` Rob Herring
2015-04-27 15:20 ` Rob Herring
2015-04-27 18:45 ` Paul Kocialkowski
2015-04-27 18:45 ` Paul Kocialkowski
2015-04-28 16:09 ` Russell King - ARM Linux
2015-04-28 16:09 ` Russell King - ARM Linux
2015-05-02 15:46 ` Paul Kocialkowski
2015-05-02 15:46 ` Paul Kocialkowski
2015-05-06 9:01 ` Russell King - ARM Linux
2015-05-06 9:01 ` Russell King - ARM Linux
2015-05-06 9:37 ` Paul Kocialkowski
2015-05-06 9:37 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430123248.3081.1.camel@collins \
--to=contact@paulk.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.