[PATCH] e2fsprogs: install populate-extfs.sh

[PATCH] e2fsprogs: install populate-extfs.sh

[Martin Jansa]

* install populate-extfs.sh from contrib, be aware that in order
  to use it you need to set DEBUGFS shell variable, otherwise it will
  try to use debugfs from relative path which is almost always
  incorrect:
    CONTRIB_DIR=$(dirname $(readlink -f $0))
    DEBUGFS="$CONTRIB_DIR/../debugfs/debugfs"

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.9.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.9.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.9.bb
index 67a5ea7..be1db9e 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.9.bb
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.9.bb
@@ -54,6 +54,8 @@ do_install () {
 	oe_multilib_header ext2fs/ext2_types.h
 	install -d ${D}${base_bindir}
 	mv ${D}${bindir}/chattr ${D}${base_bindir}/chattr.e2fsprogs
+
+	install -v -m 755 ${S}/contrib/populate-extfs.sh ${D}${base_sbindir}/
 }
 
 do_install_append_class-target() {
-- 
2.3.5

Re: [PATCH] e2fsprogs: install populate-extfs.sh

[Richard Purdie]

On Wed, 2015-04-29 at 00:46 +0200, Martin Jansa wrote:
> * install populate-extfs.sh from contrib, be aware that in order
>   to use it you need to set DEBUGFS shell variable, otherwise it will
>   try to use debugfs from relative path which is almost always
>   incorrect:
>     CONTRIB_DIR=$(dirname $(readlink -f $0))
>     DEBUGFS="$CONTRIB_DIR/../debugfs/debugfs"
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.9.bb | 2 ++
>  1 file changed, 2 insertions(+)

Do we need this now we have support proper in mkfs.ext for populating
root filesystems?

Cheers,

Richard

Re: [PATCH] e2fsprogs: install populate-extfs.sh

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

We still have some functions which use populate-extfs.sh to create some
ext4 partitions, eventually we should move to mkfs.ext as well, but as long
as it's included in e3fsprogs it makes the migration to newer oe-core
easier.

On Wed, Apr 29, 2015 at 11:56 PM, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Wed, 2015-04-29 at 00:46 +0200, Martin Jansa wrote:
> > * install populate-extfs.sh from contrib, be aware that in order
> >   to use it you need to set DEBUGFS shell variable, otherwise it will
> >   try to use debugfs from relative path which is almost always
> >   incorrect:
> >     CONTRIB_DIR=$(dirname $(readlink -f $0))
> >     DEBUGFS="$CONTRIB_DIR/../debugfs/debugfs"
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.9.bb | 2 ++
> >  1 file changed, 2 insertions(+)
>
> Do we need this now we have support proper in mkfs.ext for populating
> root filesystems?
>
> Cheers,
>
> Richard
>
>

[-- Attachment #2: Type: text/html, Size: 1557 bytes --]