All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Mark Fasheh <mfasheh@suse.de>
Cc: ocfs2-devel@oss.oracle.com, LKML <linux-kernel@vger.kernel.org>
Subject: [Ocfs2-devel] [PATCH next] ocfs2: Reduce object size of mlog uses
Date: Wed, 29 Apr 2015 22:05:46 -0700	[thread overview]
Message-ID: <1430370346.2575.12.camel@perches.com> (raw)
In-Reply-To: <20150428183007.GT17170@wotan.suse.de>

On Tue, 2015-04-28 at 11:30 -0700, Mark Fasheh wrote:
> On Thu, Apr 23, 2015 at 04:35:21PM -0700, Joe Perches wrote:
> > On Thu, 2015-04-23 at 16:04 -0700, Mark Fasheh wrote:
> > > On Wed, Apr 22, 2015 at 03:46:04PM -0700, Andrew Morton wrote:
> > > > If you feel like undertaking such a rotorooting then go wild - that should
> > > > wake 'em up ;)
> > > Ok, I've taken the bait  :)
> > "Here fishy, fishy...", erm, "Here Fasheh, Fasheh..."
> > With that out of the way:
> :)

Yeah.  Sorry 'bout that.

My own name is vaguely aquatic too so I thought I
could get away with it.  Bad Joe...

> > A couple of possibilities:
> > 
> > o I wonder whether or not file/func/line matter at all.
> >   I think they don't.
> >   Removing them would reduce code size ~90K
> 
> They do to those that are debugging live Ocfs2 modules. I would like at
> least one pair kept please.

Your code, your choice.

> > o There's a small logging improvement possible in tcp.c.
> This part looks good to me though, thanks for it.

Please submit something like it whenever you deem
appropriate.

cheers, Joe

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Mark Fasheh <mfasheh@suse.de>
Cc: ocfs2-devel@oss.oracle.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Ocfs2-devel] [PATCH next] ocfs2: Reduce object size of mlog uses
Date: Wed, 29 Apr 2015 22:05:46 -0700	[thread overview]
Message-ID: <1430370346.2575.12.camel@perches.com> (raw)
In-Reply-To: <20150428183007.GT17170@wotan.suse.de>

On Tue, 2015-04-28 at 11:30 -0700, Mark Fasheh wrote:
> On Thu, Apr 23, 2015 at 04:35:21PM -0700, Joe Perches wrote:
> > On Thu, 2015-04-23 at 16:04 -0700, Mark Fasheh wrote:
> > > On Wed, Apr 22, 2015 at 03:46:04PM -0700, Andrew Morton wrote:
> > > > If you feel like undertaking such a rotorooting then go wild - that should
> > > > wake 'em up ;)
> > > Ok, I've taken the bait  :)
> > "Here fishy, fishy...", erm, "Here Fasheh, Fasheh..."
> > With that out of the way:
> :)

Yeah.  Sorry 'bout that.

My own name is vaguely aquatic too so I thought I
could get away with it.  Bad Joe...

> > A couple of possibilities:
> > 
> > o I wonder whether or not file/func/line matter at all.
> >   I think they don't.
> >   Removing them would reduce code size ~90K
> 
> They do to those that are debugging live Ocfs2 modules. I would like at
> least one pair kept please.

Your code, your choice.

> > o There's a small logging improvement possible in tcp.c.
> This part looks good to me though, thanks for it.

Please submit something like it whenever you deem
appropriate.

cheers, Joe



  reply	other threads:[~2015-04-30  5:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-17  7:17 [Ocfs2-devel] [PATCH next] ocfs2: Reduce object size of mlog uses Joe Perches
2015-04-17  7:17 ` Joe Perches
2015-04-22 22:46 ` [Ocfs2-devel] " Andrew Morton
2015-04-22 22:46   ` Andrew Morton
2015-04-23  2:34   ` [Ocfs2-devel] " Joe Perches
2015-04-23  2:34     ` Joe Perches
2015-04-23  7:25   ` [Ocfs2-devel] [PATCH V2 -next] " Joe Perches
2015-04-23  7:25     ` Joe Perches
2015-04-23 23:04   ` [Ocfs2-devel] [PATCH next] " Mark Fasheh
2015-04-23 23:04     ` Mark Fasheh
2015-04-23 23:19     ` [Ocfs2-devel] " Andrew Morton
2015-04-23 23:19       ` Andrew Morton
2015-04-23 23:37       ` [Ocfs2-devel] " Richard Weinberger
2015-04-23 23:37         ` Richard Weinberger
2015-04-24 20:31         ` [Ocfs2-devel] " Mark Fasheh
2015-04-24 20:31           ` Mark Fasheh
2015-04-23 23:35     ` Joe Perches
2015-04-23 23:35       ` Joe Perches
2015-04-28 18:30       ` [Ocfs2-devel] " Mark Fasheh
2015-04-28 18:30         ` Mark Fasheh
2015-04-30  5:05         ` Joe Perches [this message]
2015-04-30  5:05           ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430370346.2575.12.camel@perches.com \
    --to=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfasheh@suse.de \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.