From: Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
To: Marek Belisko <marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
Cc: perex-/Fr2/VpizcU@public.gmane.org,
tiwai-l3A5Bk7waGM@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org
Subject: Re: [PATCH 1/3] ASoC: Add gtm601 codec driver
Date: Fri, 01 May 2015 09:30:09 +0200 [thread overview]
Message-ID: <1430465409.2187.47.camel@x220> (raw)
In-Reply-To: <1430429283-27907-2-git-send-email-marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
Just a nit: a license mismatch.
On Thu, 2015-04-30 at 23:28 +0200, Marek Belisko wrote:
> --- /dev/null
> +++ b/sound/soc/codecs/gtm601.c
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2 of the License, or (at your
> + * option) any later version.
This states the license is GPL v2 or later.
> +MODULE_LICENSE("GPL v2");
And, according to include/linux/module.h, this states the license is
(just) GPL v2. So I think either the comment at the top of this file or
the ident used in the MODULE_LICESE() macro should change.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle@tiscali.nl>
To: Marek Belisko <marek@goldelico.com>
Cc: perex@perex.cz, tiwai@suse.de, broonie@kernel.org,
hns@goldelico.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/3] ASoC: Add gtm601 codec driver
Date: Fri, 01 May 2015 09:30:09 +0200 [thread overview]
Message-ID: <1430465409.2187.47.camel@x220> (raw)
In-Reply-To: <1430429283-27907-2-git-send-email-marek@goldelico.com>
Just a nit: a license mismatch.
On Thu, 2015-04-30 at 23:28 +0200, Marek Belisko wrote:
> --- /dev/null
> +++ b/sound/soc/codecs/gtm601.c
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2 of the License, or (at your
> + * option) any later version.
This states the license is GPL v2 or later.
> +MODULE_LICENSE("GPL v2");
And, according to include/linux/module.h, this states the license is
(just) GPL v2. So I think either the comment at the top of this file or
the ident used in the MODULE_LICESE() macro should change.
Paul Bolle
next prev parent reply other threads:[~2015-05-01 7:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 21:28 [PATCH 0/3] ASoC: Add gtm601 simple codec Marek Belisko
2015-04-30 21:28 ` [PATCH 1/3] ASoC: Add gtm601 codec driver Marek Belisko
[not found] ` <1430429283-27907-2-git-send-email-marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2015-05-01 7:30 ` Paul Bolle [this message]
2015-05-01 7:30 ` Paul Bolle
2015-05-01 11:39 ` Belisko Marek
2015-05-01 11:39 ` Belisko Marek
2015-05-01 11:03 ` Mark Brown
[not found] ` <20150501110311.GV22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-01 11:36 ` Belisko Marek
2015-05-01 11:36 ` Belisko Marek
2015-05-01 14:02 ` Mark Brown
2015-05-01 20:34 ` Belisko Marek
2015-04-30 21:28 ` [PATCH 2/3] Documentation: devicetree: sound: Add documentation for gtm601 codec Marek Belisko
2015-04-30 21:28 ` [PATCH 3/3] Documentation: vendor-prefixes: Add option prefix Marek Belisko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430465409.2187.47.camel@x220 \
--to=pebolle-iwqwacnznjzz+pzb47itoq@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=tiwai-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.