From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [OSSTEST PATCH 4/6] sg-report-flight: Better choice of column-head cell
Date: Fri, 1 May 2015 16:19:51 +0100 [thread overview]
Message-ID: <1430493591.15640.66.camel@citrix.com> (raw)
In-Reply-To: <1430492568-1761-5-git-send-email-ian.jackson@eu.citrix.com>
On Fri, 2015-05-01 at 16:02 +0100, Ian Jackson wrote:
> We are more interested the first worst failure. But if everything
^in ?
> passed, then the last pass.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
> sg-report-flight | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sg-report-flight b/sg-report-flight
> index 29b5ef6..7c9e52e 100755
> --- a/sg-report-flight
> +++ b/sg-report-flight
> @@ -949,7 +949,7 @@ END
> }
> print H "\n";
> print H "<tr><th>";
> - print H "Worst/last";
> + print H "Last pass / First worst fail";
> print H "</th>";
>
> my $cell_html = sub {
> @@ -990,6 +990,7 @@ END
> next unless $ei;
> my @this = $cell_html->($ei);
> next if $this[1] < $worst[1];
> + next if $this[1] == $worst[1] && $ei->{Step}{status} ne 'pass';
> @worst=@this;
> }
> print H "<td ",$worst[2],">",$worst[0],"</td>";
next prev parent reply other threads:[~2015-05-01 15:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 11:27 [xen-4.4-testing test] 52629: regressions - FAIL osstest service user
2015-05-01 11:36 ` Ian Campbell
2015-05-01 11:48 ` Ian Campbell
2015-05-01 12:58 ` Ian Jackson
2015-05-01 15:02 ` [OSSTEST PATCH 0/6] Urgent performance improvements Ian Jackson
2015-05-01 15:02 ` [OSSTEST PATCH 1/6] cs-bisection-step: Use pbm tools, not graphicsmagick/imagemagick Ian Jackson
2015-05-01 15:02 ` [OSSTEST PATCH 2/6] sg-report-job-history: Avoid full runvars table scan (!) Ian Jackson
2015-05-01 15:18 ` Ian Campbell
2015-05-01 15:02 ` [OSSTEST PATCH 3/6] sg-report-flight: Break colour of out $cell_html->() results Ian Jackson
2015-05-01 15:02 ` [OSSTEST PATCH 4/6] sg-report-flight: Better choice of column-head cell Ian Jackson
2015-05-01 15:19 ` Ian Campbell [this message]
2015-05-01 15:02 ` [OSSTEST PATCH 5/6] sg-report-flight: Include actual status in column-head cells Ian Jackson
2015-05-01 15:02 ` [OSSTEST PATCH 6/6] sg-report-flight: Report stepno and testid of first worst fail Ian Jackson
2015-05-01 15:27 ` Ian Campbell
2015-05-01 15:34 ` Ian Jackson
2015-05-01 15:28 ` [OSSTEST PATCH 0/6] Urgent performance improvements Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430493591.15640.66.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.