Re: [PATCH v6 13/14] tools: add tools support for Intel CAT

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2255 bytes --]

On Tue, 2015-05-05 at 13:52 +0100, Ian Campbell wrote:
> On Thu, 2015-04-23 at 17:55 +0800, Chao Peng wrote:

> > @@ -1495,10 +1495,20 @@ for any of these monitoring types.
> >  
> >  =over 4
> >  
> > -=item B<psr-hwinfo>
> > +=item B<psr-hwinfo> [I<OPTIONS>]
> >  
> >  Show CMT hardware information.
> >  
> > +B<OPTIONS>
> > +
> > +=over 4
> > +
> > +=item B<-m>, B<--cmt>
> > +
> > +Show Cache Monitoring Technology (CMT) hardware information.
> 
> Duplicating the psr-hwinfo case for CMT and CAT is confusing.
> 
> I suggest to add =head1 <WHATEVER PSR STANDS FOR> and to push the
> existing "=head1 CACHE MONITORING TECHNOLOGY" to a =head2, and the same
> for the new CACHE ALLOCATION TECHNOLOGY section.
> 
> i.e. have an overall PSR section and then subsections for CMT and CAT.
> 
> psr-hwinfo would then be described at the top level and the CMD/CAT
> specifics in the relevant section.
> 
> Does that sound ok?
> 
+1

> > +=head1 CACHE ALLOCATION TECHNOLOGY
> > +
> > +Intel Broadwell and later server platforms offer capabilities to configure and
> > +make use of the Cache Allocation Technology (CAT) mechanisms, which enable more
> > +cache resources (i.e. L3 cache) to be made available for high priority
> > +applications. In Xen implementation, CAT is used to control cache allocation
>                    ^the
> 
> > diff --git a/tools/libxl/xl_cmdtable.c b/tools/libxl/xl_cmdtable.c
> > index b81b3ff..eede5f1 100644
> > --- a/tools/libxl/xl_cmdtable.c
> > +++ b/tools/libxl/xl_cmdtable.c
> > @@ -527,7 +527,9 @@ struct cmd_spec cmd_table[] = {
> >      { "psr-hwinfo",
> >        &main_psr_hwinfo, 0, 1,
> >        "Show hardware information for Platform Shared Resource",
> > -      "",
> > +      "[options]",
> > +      "-m <cmt>       Show Cache Monitoring Technology (CMT) hardware info\n"
> > +      "-a <cat>       Show Cache Allocation Technology (CAT) hardware info\n"
> 
> <cmt> and <cat> seem out of place here, since -m and -a do not take
> options AFAICT.
> 
Chao, maybe you meant something like this?

 "-m, --cmt      Show Cache Monitoring Technology (CMT) hardware info\n"
 "-a, --cat      Show Cache Allocation Technology (CAT) hardware info\n"

Dario

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel