All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH v2] config: generate Paths-$SUBSYSTEM.mk
Date: Fri, 8 May 2015 15:43:14 +0100	[thread overview]
Message-ID: <1431096194.2660.484.camel@citrix.com> (raw)
In-Reply-To: <1430888562-3745-1-git-send-email-wei.liu2@citrix.com>

On Wed, 2015-05-06 at 06:02 +0100, Wei Liu wrote:
> ... so that we can run ./configure in each subsystem.
> 
> Make inclusion of Paths-*.mk mandatory. Skip generating a global
> Paths.mk since it's of no use anymore.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> v2: update .gitignore, delete Paths-*.mk in distclean
> 
> Please rerun autogen.sh when applying this patch.

With this applied the list of installed files changes in a way which is
clearly not desirable ;-).

Looks like the stubdom case is not correctly handled?

--- ../FILE_LIST.BASE.staging.x86_64    2015-04-15 16:03:29.000000000 +0100
+++ ../FILE_LIST.staging.x86_64 2015-05-08 15:41:21.000000000 +0100
@@ -56,6 +56,9 @@
 dist/install/etc/xen/xl.conf
 dist/install/etc/xen/xlexample.hvm
 dist/install/etc/xen/xlexample.pvlinux
+dist/install@LIBEXEC_BIN@
+dist/install@LIBEXEC_BIN@/stubdom-dm
+dist/install@LIBEXEC_BIN@/stubdompath.sh
 dist/install.sh
 dist/install/usr
 dist/install/usr/local
@@ -337,8 +340,6 @@
 dist/install/usr/local/lib/xen/bin/qemu-nbd
 dist/install/usr/local/lib/xen/bin/qemu-system-i386
 dist/install/usr/local/lib/xen/bin/readnotes
-dist/install/usr/local/lib/xen/bin/stubdom-dm
-dist/install/usr/local/lib/xen/bin/stubdompath.sh
 dist/install/usr/local/lib/xen/bin/xenconsole
 dist/install/usr/local/lib/xen/bin/xenctx
 dist/install/usr/local/lib/xen/bin/xendomains
@@ -347,12 +348,6 @@
 dist/install/usr/local/lib/xen/bin/xenpvnetboot
 dist/install/usr/local/lib/xen/boot
 dist/install/usr/local/lib/xen/boot/hvmloader
-dist/install/usr/local/lib/xen/boot/ioemu-stubdom.gz
-dist/install/usr/local/lib/xen/boot/pv-grub-x86_32.gz
-dist/install/usr/local/lib/xen/boot/pv-grub-x86_64.gz
-dist/install/usr/local/lib/xen/boot/vtpmmgr-stubdom.gz
-dist/install/usr/local/lib/xen/boot/vtpm-stubdom.gz
-dist/install/usr/local/lib/xen/boot/xenstore-stubdom.gz
 dist/install/usr/local/lib/xen/etc
 dist/install/usr/local/lib/xen/etc/qemu
 dist/install/usr/local/lib/xen/etc/qemu/target-x86_64.conf
@@ -785,4 +780,11 @@
 dist/install/var/log/xen
 dist/install/var/xen
 dist/install/var/xen/dump
+dist/install@XENFIRMWAREDIR@
+dist/install@XENFIRMWAREDIR@/ioemu-stubdom.gz
+dist/install@XENFIRMWAREDIR@/pv-grub-x86_32.gz
+dist/install@XENFIRMWAREDIR@/pv-grub-x86_64.gz
+dist/install@XENFIRMWAREDIR@/vtpmmgr-stubdom.gz
+dist/install@XENFIRMWAREDIR@/vtpm-stubdom.gz
+dist/install@XENFIRMWAREDIR@/xenstore-stubdom.gz
 dist/README
*** FILES DIFFER ***

  reply	other threads:[~2015-05-08 14:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06  5:02 [PATCH v2] config: generate Paths-$SUBSYSTEM.mk Wei Liu
2015-05-08 14:43 ` Ian Campbell [this message]
2015-05-08 15:20   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431096194.2660.484.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.