[Cocci] [PATCH 1/4] coccinelle: pm_runtime: Insert blank line

[Cocci] [PATCH 1/4] coccinelle: pm_runtime: Insert blank line

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

Insert a blank line in order to improve the readability of the 
generated patch and also make it consistent with the other 
.cocci files.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 scripts/coccinelle/api/pm_runtime.cocci | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/coccinelle/api/pm_runtime.cocci b/scripts/coccinelle/api/pm_runtime.cocci
index f01789e..9208aa1 100644
--- a/scripts/coccinelle/api/pm_runtime.cocci
+++ b/scripts/coccinelle/api/pm_runtime.cocci
@@ -1,4 +1,5 @@
 /// Make sure pm_runtime_* calls does not use unnecessary IS_ERR_VALUE
+///
 //
 // Keywords: pm_runtime
 // Confidence: Medium
-- 
1.9.1

[Cocci] [PATCH 2/4] coccinelle: returnvar: Use imperative mood

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

According to Documentation/SubmittingPatches:

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour."

So do as recommended.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 scripts/coccinelle/misc/returnvar.cocci | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coccinelle/misc/returnvar.cocci b/scripts/coccinelle/misc/returnvar.cocci
index 605955a..d8286ef 100644
--- a/scripts/coccinelle/misc/returnvar.cocci
+++ b/scripts/coccinelle/misc/returnvar.cocci
@@ -1,5 +1,5 @@
 ///
-/// Removes unneeded variable used to store return value.
+/// Remove unneeded variable used to store return value.
 ///
 // Confidence: Moderate
 // Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6.  GPLv2.
-- 
1.9.1

[Cocci] [PATCH 2/4] coccinelle: returnvar: Use imperative mood

[Julia Lawall]

On Sat, 9 May 2015, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> According to Documentation/SubmittingPatches:
> 
> "Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
> instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
> to do frotz", as if you are giving orders to the codebase to change
> its behaviour."
> 
> So do as recommended.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
>  scripts/coccinelle/misc/returnvar.cocci | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coccinelle/misc/returnvar.cocci b/scripts/coccinelle/misc/returnvar.cocci
> index 605955a..d8286ef 100644
> --- a/scripts/coccinelle/misc/returnvar.cocci
> +++ b/scripts/coccinelle/misc/returnvar.cocci
> @@ -1,5 +1,5 @@
>  ///
> -/// Removes unneeded variable used to store return value.
> +/// Remove unneeded variable used to store return value.
>  ///
>  // Confidence: Moderate
>  // Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6.  GPLv2.
> -- 
> 1.9.1
> 
> 

[Cocci] [PATCH 3/4] coccinelle: ifaddr: Fix the sentence

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

Make the sentence sensible.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 scripts/coccinelle/misc/ifaddr.cocci | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/coccinelle/misc/ifaddr.cocci b/scripts/coccinelle/misc/ifaddr.cocci
index 8aebd18..c2663c6 100644
--- a/scripts/coccinelle/misc/ifaddr.cocci
+++ b/scripts/coccinelle/misc/ifaddr.cocci
@@ -1,5 +1,4 @@
-/// the address of a variable or field is non-zero is likely always to bo
-/// non-zero
+/// The address of a variable or field is likely always to be non-zero.
 ///
 // Confidence: High
 // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6.  GPLv2.
-- 
1.9.1

[Cocci] [PATCH 3/4] coccinelle: ifaddr: Fix the sentence

[Julia Lawall]

On Sat, 9 May 2015, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Make the sentence sensible.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
>  scripts/coccinelle/misc/ifaddr.cocci | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/scripts/coccinelle/misc/ifaddr.cocci b/scripts/coccinelle/misc/ifaddr.cocci
> index 8aebd18..c2663c6 100644
> --- a/scripts/coccinelle/misc/ifaddr.cocci
> +++ b/scripts/coccinelle/misc/ifaddr.cocci
> @@ -1,5 +1,4 @@
> -/// the address of a variable or field is non-zero is likely always to bo
> -/// non-zero
> +/// The address of a variable or field is likely always to be non-zero.
>  ///
>  // Confidence: High
>  // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6.  GPLv2.
> -- 
> 1.9.1
> 
> 

[Cocci] [PATCH 4/4] coccinelle: simple_open: Use imperative mood

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

According to Documentation/SubmittingPatches:

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour."

So do as recommended.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 scripts/coccinelle/api/simple_open.cocci | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/coccinelle/api/simple_open.cocci b/scripts/coccinelle/api/simple_open.cocci
index b67e174..bd1a2a4 100644
--- a/scripts/coccinelle/api/simple_open.cocci
+++ b/scripts/coccinelle/api/simple_open.cocci
@@ -1,5 +1,5 @@
-/// This removes an open coded simple_open() function
-/// and replaces file operations references to the function
+/// Remove an open coded simple_open() function
+/// and replace file operations references to the function
 /// with simple_open() instead.
 ///
 // Confidence: High
-- 
1.9.1

[Cocci] [PATCH 4/4] coccinelle: simple_open: Use imperative mood

[Julia Lawall]

On Sat, 9 May 2015, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> According to Documentation/SubmittingPatches:
> 
> "Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
> instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
> to do frotz", as if you are giving orders to the codebase to change
> its behaviour."
> 
> So do as recommended.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
>  scripts/coccinelle/api/simple_open.cocci | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/coccinelle/api/simple_open.cocci b/scripts/coccinelle/api/simple_open.cocci
> index b67e174..bd1a2a4 100644
> --- a/scripts/coccinelle/api/simple_open.cocci
> +++ b/scripts/coccinelle/api/simple_open.cocci
> @@ -1,5 +1,5 @@
> -/// This removes an open coded simple_open() function
> -/// and replaces file operations references to the function
> +/// Remove an open coded simple_open() function
> +/// and replace file operations references to the function
>  /// with simple_open() instead.
>  ///
>  // Confidence: High
> -- 
> 1.9.1
> 
> 

[Cocci] [PATCH 1/4] coccinelle: pm_runtime: Insert blank line

[Julia Lawall]

On Sat, 9 May 2015, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Insert a blank line in order to improve the readability of the 
> generated patch and also make it consistent with the other 
> .cocci files.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  scripts/coccinelle/api/pm_runtime.cocci | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/coccinelle/api/pm_runtime.cocci b/scripts/coccinelle/api/pm_runtime.cocci
> index f01789e..9208aa1 100644
> --- a/scripts/coccinelle/api/pm_runtime.cocci
> +++ b/scripts/coccinelle/api/pm_runtime.cocci
> @@ -1,4 +1,5 @@
>  /// Make sure pm_runtime_* calls does not use unnecessary IS_ERR_VALUE
> +///
>  //

Looking at the examples in the other fixes you have sent, it seems that 
what is wanted it to convert the // to /// rather than adding a /// before 
it.

Thanks for your help.

julia

>  // Keywords: pm_runtime
>  // Confidence: Medium
> -- 
> 1.9.1
> 
>