All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xen/xsm: Fix x86 XSM build after commit 6ea9f04
@ 2015-05-11 10:09 Julien Grall
  2015-05-11 10:48 ` Ian Campbell
  0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2015-05-11 10:09 UTC (permalink / raw)
  To: xen-devel; +Cc: Julien Grall, andrew.cooper3, dgdegra, ian.campbell, jbeulich

Signed-off-by: Julien Grall <julien.grall@citrix.com>
---
 xen/xsm/flask/flask_op.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/xen/xsm/flask/flask_op.c b/xen/xsm/flask/flask_op.c
index 802ffd4..8dee021 100644
--- a/xen/xsm/flask/flask_op.c
+++ b/xen/xsm/flask/flask_op.c
@@ -829,10 +829,10 @@ CHECK_flask_setenforce;
 CHECK_flask_transition;
 
 #define COMPAT
-#define flask_copyin_string(ch, pb, sz, mx) ({ \
-	XEN_GUEST_HANDLE_PARAM(char) gh; \
-	guest_from_compat_handle(gh, ch); \
-	flask_copyin_string(gh, pb, sz, mx); \
+#define safe_copy_string_from_guest(ch, sz, mx) ({ \
+    XEN_GUEST_HANDLE_PARAM(char) gh; \
+    guest_from_compat_handle(gh, ch); \
+    safe_copy_string_from_guest(gh, sz, mx); \
 })
 
 #define xen_flask_load compat_flask_load
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] xen/xsm: Fix x86 XSM build after commit 6ea9f04
  2015-05-11 10:09 [PATCH] xen/xsm: Fix x86 XSM build after commit 6ea9f04 Julien Grall
@ 2015-05-11 10:48 ` Ian Campbell
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2015-05-11 10:48 UTC (permalink / raw)
  To: Julien Grall; +Cc: xen-devel, dgdegra, jbeulich, andrew.cooper3

On Mon, 2015-05-11 at 11:09 +0100, Julien Grall wrote:
> Signed-off-by: Julien Grall <julien.grall@citrix.com>

Applied, thanks.

(NB: I prefer commit logs which explain how they fix the build)


> ---
>  xen/xsm/flask/flask_op.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/xsm/flask/flask_op.c b/xen/xsm/flask/flask_op.c
> index 802ffd4..8dee021 100644
> --- a/xen/xsm/flask/flask_op.c
> +++ b/xen/xsm/flask/flask_op.c
> @@ -829,10 +829,10 @@ CHECK_flask_setenforce;
>  CHECK_flask_transition;
>  
>  #define COMPAT
> -#define flask_copyin_string(ch, pb, sz, mx) ({ \
> -	XEN_GUEST_HANDLE_PARAM(char) gh; \
> -	guest_from_compat_handle(gh, ch); \
> -	flask_copyin_string(gh, pb, sz, mx); \
> +#define safe_copy_string_from_guest(ch, sz, mx) ({ \
> +    XEN_GUEST_HANDLE_PARAM(char) gh; \
> +    guest_from_compat_handle(gh, ch); \
> +    safe_copy_string_from_guest(gh, sz, mx); \
>  })
>  
>  #define xen_flask_load compat_flask_load

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-11 10:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-11 10:09 [PATCH] xen/xsm: Fix x86 XSM build after commit 6ea9f04 Julien Grall
2015-05-11 10:48 ` Ian Campbell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.