From: Ian Campbell <ian.campbell@citrix.com>
To: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com,
andrew.cooper3@citrix.com, yunhong.jiang@intel.com,
eddie.dong@intel.com, xen-devel@lists.xen.org,
guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca,
ian.jackson@eu.citrix.com
Subject: Re: [PATCH v6 02/16] libxc/save: Adjust stream-position callbacks for checkpointed streams
Date: Thu, 14 May 2015 12:19:44 +0100 [thread overview]
Message-ID: <1431602384.13579.39.camel@citrix.com> (raw)
In-Reply-To: <1431593718-4828-3-git-send-email-yanghy@cn.fujitsu.com>
On Thu, 2015-05-14 at 16:55 +0800, Yang Hongyang wrote:
> From: Andrew Cooper <andrew.cooper3@citrix.com>
>
> There are some records which should only be sent once in the stream, and not
> repeated for each checkpoint. {start,end}_of_stream() become per-checkpoint,
> and a new start_of_stream() is introduced.
>
> There is no resulting change record order, but the X86_PV_INFO record is
> identified as once per stream. Currently the X86_PV_P2M_FRAMES record is as
> well, but this is because of an implementation bug and can move back to being
> on an as-needed basis when fixed.
>
> In addition, a few minor adjustments of comments and layout.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
You pointed me to the docs in v5, so my previous
Acked-by: Ian Campbell <Ian.Campbell@citrix.com>
stands.
(just replying here so I don't have to check two threads when I come to
reply).
next prev parent reply other threads:[~2015-05-14 11:19 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 8:55 [PATCH v6 00/16] Misc patches to aid migration v2 Remus support Yang Hongyang
2015-05-14 8:55 ` [PATCH v6 01/16] libxc/migration: Be rather stricter with illformed callers Yang Hongyang
2015-05-14 8:55 ` [PATCH v6 02/16] libxc/save: Adjust stream-position callbacks for checkpointed streams Yang Hongyang
2015-05-14 11:19 ` Ian Campbell [this message]
2015-05-14 8:55 ` [PATCH v6 03/16] libxc/migration: Specification update for CHECKPOINT records Yang Hongyang
2015-05-14 8:55 ` [PATCH v6 04/16] libxc/migration: Pass checkpoint information into the save algorithm Yang Hongyang
2015-05-14 11:21 ` Ian Campbell
2015-05-14 11:59 ` Ian Campbell
2015-05-14 8:55 ` [PATCH v6 05/16] tools/libxc: unused attribute in DECLARE_HYPERCALL_BUFFER_SHADOW Yang Hongyang
2015-05-14 11:22 ` Ian Campbell
2015-05-14 8:55 ` [PATCH v6 06/16] tools/libxc: add a check in xc_hypercall_buffer_free_pages macro Yang Hongyang
2015-05-14 11:24 ` Ian Campbell
2015-05-14 8:55 ` [PATCH v6 07/16] libxc/save: introduce setup() and cleanup() on save Yang Hongyang
2015-05-14 11:25 ` Ian Campbell
2015-05-14 8:55 ` [PATCH v6 08/16] libxc/save: rename to_send to dirty_bitmap Yang Hongyang
2015-05-14 11:25 ` Ian Campbell
2015-05-14 8:55 ` [PATCH v6 09/16] libxc/save: adjust the memory allocation for migration Yang Hongyang
2015-05-14 11:26 ` Ian Campbell
2015-05-14 8:55 ` [PATCH v6 10/16] libxc/save: remove bitmap param from send_some_pages Yang Hongyang
2015-05-14 11:27 ` Ian Campbell
2015-05-14 8:55 ` [PATCH v6 11/16] libxc/save: rename send_some_pages to send_dirty_pages Yang Hongyang
2015-05-14 8:59 ` Andrew Cooper
2015-05-14 11:27 ` Ian Campbell
2015-05-14 8:55 ` [PATCH v6 12/16] libxc/save: reuse send_dirty_pages() in send_all_pages() Yang Hongyang
2015-05-14 11:28 ` Ian Campbell
2015-05-14 8:55 ` [PATCH v6 13/16] libxc/restore: introduce process_record() Yang Hongyang
2015-05-14 11:28 ` Ian Campbell
2015-05-14 8:55 ` [PATCH v6 14/16] libxc/restore: split read/handle qemu info Yang Hongyang
2015-05-14 11:33 ` Ian Campbell
2015-05-14 8:55 ` [PATCH v6 15/16] libxc/restore: introduce setup() and cleanup() on restore Yang Hongyang
2015-05-14 9:01 ` Andrew Cooper
2015-05-14 11:33 ` Ian Campbell
2015-05-14 8:55 ` [PATCH v6 16/16] libxc/restore: add checkpointed flag to the restore context Yang Hongyang
2015-05-14 11:34 ` Ian Campbell
2015-05-14 12:35 ` [PATCH v6 00/16] Misc patches to aid migration v2 Remus support Ian Campbell
2015-05-15 1:05 ` Yang Hongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431602384.13579.39.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=ian.jackson@eu.citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=wei.liu2@citrix.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.