From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 07/10] pinctrl: sunxi: Add H3 PIO controller support
Date: Sat, 16 May 2015 17:32:25 +0200 [thread overview]
Message-ID: <1431790345.2341.37.camel@x220> (raw)
In-Reply-To: <1431707940-19372-8-git-send-email-jenskuske@gmail.com>
Just a nit: a license mismatch.
(I didn't bring this up in v1. Perhaps I should have.)
On Fri, 2015-05-15 at 18:38 +0200, Jens Kuske wrote:
> --- /dev/null
> +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
This states the license is GPL v2.
> +MODULE_LICENSE("GPL");
According to include/linux/module.h this states the license is GPL v2 or
later. So I think that either the comment at the top of this file or the
ident used in the MODULE_LICENSE() macro needs to change.
Paul Bolle
WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
To: Jens Kuske <jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Maxime Ripard"
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"Emilio López" <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>,
"Mike Turquette"
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Linus Walleij"
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Chen-Yu Tsai" <wens-jdAy2FN1RRM@public.gmane.org>,
"Vishnu Patekar"
<vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Hans de Goede"
<hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v2 07/10] pinctrl: sunxi: Add H3 PIO controller support
Date: Sat, 16 May 2015 17:32:25 +0200 [thread overview]
Message-ID: <1431790345.2341.37.camel@x220> (raw)
In-Reply-To: <1431707940-19372-8-git-send-email-jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Just a nit: a license mismatch.
(I didn't bring this up in v1. Perhaps I should have.)
On Fri, 2015-05-15 at 18:38 +0200, Jens Kuske wrote:
> --- /dev/null
> +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
This states the license is GPL v2.
> +MODULE_LICENSE("GPL");
According to include/linux/module.h this states the license is GPL v2 or
later. So I think that either the comment at the top of this file or the
ident used in the MODULE_LICENSE() macro needs to change.
Paul Bolle
WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle@tiscali.nl>
To: Jens Kuske <jenskuske@gmail.com>
Cc: "Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Emilio López" <emilio@elopez.com.ar>,
"Mike Turquette" <mturquette@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Vishnu Patekar" <vishnupatekar0510@gmail.com>,
"Hans de Goede" <hdegoede@redhat.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 07/10] pinctrl: sunxi: Add H3 PIO controller support
Date: Sat, 16 May 2015 17:32:25 +0200 [thread overview]
Message-ID: <1431790345.2341.37.camel@x220> (raw)
In-Reply-To: <1431707940-19372-8-git-send-email-jenskuske@gmail.com>
Just a nit: a license mismatch.
(I didn't bring this up in v1. Perhaps I should have.)
On Fri, 2015-05-15 at 18:38 +0200, Jens Kuske wrote:
> --- /dev/null
> +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
This states the license is GPL v2.
> +MODULE_LICENSE("GPL");
According to include/linux/module.h this states the license is GPL v2 or
later. So I think that either the comment at the top of this file or the
ident used in the MODULE_LICENSE() macro needs to change.
Paul Bolle
next prev parent reply other threads:[~2015-05-16 15:32 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 16:38 [PATCH v2 00/10] ARM: sunxi: Introduce Allwinner H3 support Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-15 16:38 ` [PATCH v2 01/10] Documentation: sunxi: Update Allwinner SoC documentation Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-17 12:52 ` Maxime Ripard
2015-05-17 12:52 ` Maxime Ripard
2015-05-17 12:52 ` Maxime Ripard
2015-05-15 16:38 ` [PATCH v2 02/10] clk: sunxi: Add support for multiple parents to gates Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-17 12:50 ` Maxime Ripard
2015-05-17 12:50 ` Maxime Ripard
2015-05-17 12:50 ` Maxime Ripard
2015-05-18 9:11 ` Jens Kuske
2015-05-18 9:11 ` Jens Kuske
2015-05-18 9:11 ` Jens Kuske
2015-05-19 7:53 ` Maxime Ripard
2015-05-19 7:53 ` Maxime Ripard
2015-05-19 7:53 ` Maxime Ripard
2015-05-15 16:38 ` [PATCH v2 03/10] clk: sunxi: Let divs clocks read the base factor clock name from devicetree Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-15 16:38 ` Jens Kuske
[not found] ` <1431707940-19372-4-git-send-email-jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-16 2:10 ` Chen-Yu Tsai
2015-05-18 9:15 ` Jens Kuske
2015-05-18 9:15 ` Jens Kuske
2015-05-18 9:15 ` Jens Kuske
2015-05-18 14:45 ` Chen-Yu Tsai
2015-05-18 14:45 ` Chen-Yu Tsai
2015-05-18 14:45 ` Chen-Yu Tsai
2015-05-17 13:06 ` Maxime Ripard
2015-05-17 13:06 ` Maxime Ripard
2015-05-17 13:06 ` Maxime Ripard
2015-05-18 9:22 ` Jens Kuske
2015-05-18 9:22 ` Jens Kuske
2015-05-18 9:22 ` Jens Kuske
2015-05-19 8:26 ` Maxime Ripard
2015-05-19 8:26 ` Maxime Ripard
2015-05-19 8:26 ` Maxime Ripard
2015-05-15 16:38 ` [PATCH v2 04/10] pinctrl: sunxi: Prepare for building SoC specific drivers as modules Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-17 14:19 ` Maxime Ripard
2015-05-17 14:19 ` Maxime Ripard
2015-05-17 14:19 ` Maxime Ripard
2015-05-18 9:32 ` Jens Kuske
2015-05-18 9:32 ` Jens Kuske
2015-05-18 9:32 ` Jens Kuske
2015-05-19 7:55 ` Maxime Ripard
2015-05-19 7:55 ` Maxime Ripard
2015-05-19 8:02 ` Chen-Yu Tsai
2015-05-19 8:02 ` Chen-Yu Tsai
2015-05-19 8:02 ` Chen-Yu Tsai
2015-05-19 8:16 ` Maxime Ripard
2015-05-19 8:16 ` Maxime Ripard
2015-05-19 8:16 ` Maxime Ripard
2015-05-19 14:58 ` Linus Walleij
2015-05-19 14:58 ` Linus Walleij
2015-05-19 14:58 ` Linus Walleij
2015-05-15 16:38 ` [PATCH v2 05/10] ARM: sunxi: Introduce Allwinner H3 support Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-17 14:21 ` Maxime Ripard
2015-05-17 14:21 ` Maxime Ripard
2015-05-17 14:21 ` Maxime Ripard
2015-05-15 16:38 ` [PATCH v2 06/10] clk: sunxi: Add H3 clocks support Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-17 14:27 ` Maxime Ripard
2015-05-17 14:27 ` Maxime Ripard
2015-05-17 14:27 ` Maxime Ripard
2015-05-18 9:45 ` Jens Kuske
2015-05-18 9:45 ` Jens Kuske
2015-05-18 9:45 ` Jens Kuske
2015-05-19 8:50 ` Maxime Ripard
2015-05-19 8:50 ` Maxime Ripard
2015-05-19 8:50 ` Maxime Ripard
2015-05-15 16:38 ` [PATCH v2 07/10] pinctrl: sunxi: Add H3 PIO controller support Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-16 15:32 ` Paul Bolle [this message]
2015-05-16 15:32 ` Paul Bolle
2015-05-16 15:32 ` Paul Bolle
2015-05-17 14:30 ` Maxime Ripard
2015-05-17 14:30 ` Maxime Ripard
2015-05-17 14:30 ` Maxime Ripard
2015-05-18 9:52 ` Jens Kuske
2015-05-18 9:52 ` Jens Kuske
2015-05-18 9:52 ` Jens Kuske
2015-05-19 14:04 ` Linus Walleij
2015-05-19 14:04 ` Linus Walleij
2015-05-19 14:04 ` Linus Walleij
2015-05-19 15:03 ` Maxime Ripard
2015-05-19 15:03 ` Maxime Ripard
2015-05-19 15:03 ` Maxime Ripard
2015-05-15 16:38 ` [PATCH v2 08/10] reset: sunxi: Add compatible for Allwinner H3 bus resets Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-17 14:31 ` Maxime Ripard
2015-05-17 14:31 ` Maxime Ripard
2015-05-17 14:31 ` Maxime Ripard
2015-05-18 9:55 ` Jens Kuske
2015-05-18 9:55 ` Jens Kuske
2015-05-18 9:55 ` Jens Kuske
2015-05-15 16:38 ` [PATCH v2 09/10] ARM: dts: sunxi: Add Allwinner H3 DTSI Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-15 16:38 ` Jens Kuske
2015-05-15 16:39 ` [PATCH v2 10/10] ARM: dts: sun8i: Add Orange Pi Plus support Jens Kuske
2015-05-15 16:39 ` Jens Kuske
2015-05-15 16:39 ` Jens Kuske
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431790345.2341.37.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.