All of lore.kernel.org
 help / color / mirror / Atom feed
From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next v3 2/2] net: Adding support for Cavium ThunderX network controller
Date: Mon, 18 May 2015 10:46:37 +0200	[thread overview]
Message-ID: <1431938797.2204.12.camel@x220> (raw)
In-Reply-To: <1431747401-20847-3-git-send-email-aleksey.makarov@auriga.com>

Just a nit: a license mismatch.

On Fri, 2015-05-15 at 20:36 -0700, Aleksey Makarov wrote:
> --- /dev/null
> +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c

> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.

This states the license is GPL v2 or later. (The other files used for
this module contain an identical comment.)

> +MODULE_LICENSE("GPL v2");

And, according to include/linux/module.h, this states the license is
just GPL v2. So I think that either the license used in the comment at
the top of those files or the ident used in the MODULE_LICENSE() macro
needs to change.

Ditto for the thunder_bgx.ko and the nicvf.ko module.

Thanks,


Paul Bolle

WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle@tiscali.nl>
To: Aleksey Makarov <aleksey.makarov@auriga.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	David Daney <david.daney@cavium.com>,
	Sunil Goutham <sgoutham@cavium.com>,
	Maciej Czekaj <mjc@semihalf.com>,
	Ganapatrao Kulkarni <ganapatrao.kulkarni@caviumnetworks.com>,
	Tomasz Nowicki <tomasz.nowicki@linaro.org>,
	Robert Richter <rrichter@cavium.com>,
	Kamil Rytarowski <kamil@semihalf.com>,
	Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>,
	Sruthi Vangala <svangala@cavium.com>,
	Robert Richter <rric@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v3 2/2] net: Adding support for Cavium ThunderX network controller
Date: Mon, 18 May 2015 10:46:37 +0200	[thread overview]
Message-ID: <1431938797.2204.12.camel@x220> (raw)
In-Reply-To: <1431747401-20847-3-git-send-email-aleksey.makarov@auriga.com>

Just a nit: a license mismatch.

On Fri, 2015-05-15 at 20:36 -0700, Aleksey Makarov wrote:
> --- /dev/null
> +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c

> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.

This states the license is GPL v2 or later. (The other files used for
this module contain an identical comment.)

> +MODULE_LICENSE("GPL v2");

And, according to include/linux/module.h, this states the license is
just GPL v2. So I think that either the license used in the comment at
the top of those files or the ident used in the MODULE_LICENSE() macro
needs to change.

Ditto for the thunder_bgx.ko and the nicvf.ko module.

Thanks,


Paul Bolle


  reply	other threads:[~2015-05-18  8:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-16  3:36 [PATCH net-next v3 0/2] Adding support for Cavium ThunderX network controller Aleksey Makarov
2015-05-16  3:36 ` [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id Aleksey Makarov
2015-05-16 14:49   ` Bjorn Helgaas
2015-05-16 21:14     ` David Miller
2015-05-18 16:35       ` Bjorn Helgaas
2015-05-18 16:41         ` David Miller
2015-05-18 17:26           ` Bjorn Helgaas
2015-05-18 17:51             ` David Daney
2015-05-18 21:00   ` Aleksey Makarov
2015-05-18 21:06     ` David Miller
2015-05-16  3:36 ` [PATCH net-next v3 2/2] net: Adding support for Cavium ThunderX network controller Aleksey Makarov
2015-05-18  8:46   ` Paul Bolle [this message]
2015-05-18  8:46     ` Paul Bolle
2015-05-18 20:09   ` David Miller
2015-05-18 20:09     ` David Miller
2015-05-18 21:52     ` David Daney
2015-05-18 21:52       ` David Daney
2015-05-18 21:52       ` David Daney
2015-05-18 23:52       ` David Miller
2015-05-18 23:52         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431938797.2204.12.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.