From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RESEND] SCSI: ips: remove pointless #warning
Date: Tue, 19 May 2015 06:52:52 -0700 [thread overview]
Message-ID: <1432043572.3007.14.camel@HansenPartnership.com> (raw)
In-Reply-To: <3121960.dnOqT9LCth@wuerfel>
On Tue, 2015-05-19 at 15:33 +0200, Arnd Bergmann wrote:
> The ips driver contains
>
> #warning "This driver has only been tested on the x86/ia64/x86_64 platforms"
>
> which gets printed by the compiler every time this driver gets
> build for something other than those three architectures. The same
> is true for most other drivers, but none of them prints a warning like
> this.
>
> Let's remove the warning now to reduce the amount of clutter.
>
> FWIW, I've reviewed the driver and found a few oddities, but nothing
> that needs to be fixed or that would be architecture specific.
In principle I don't disagree. However this warning was a specific
request of the driver writers. Since the driver is pretty much dead,
I'm not sure anyone is going to check or fix it for non-intel any time
soon.
James
WARNING: multiple messages have this Message-ID (diff)
From: James.Bottomley@HansenPartnership.com (James Bottomley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [RESEND] SCSI: ips: remove pointless #warning
Date: Tue, 19 May 2015 06:52:52 -0700 [thread overview]
Message-ID: <1432043572.3007.14.camel@HansenPartnership.com> (raw)
In-Reply-To: <3121960.dnOqT9LCth@wuerfel>
On Tue, 2015-05-19 at 15:33 +0200, Arnd Bergmann wrote:
> The ips driver contains
>
> #warning "This driver has only been tested on the x86/ia64/x86_64 platforms"
>
> which gets printed by the compiler every time this driver gets
> build for something other than those three architectures. The same
> is true for most other drivers, but none of them prints a warning like
> this.
>
> Let's remove the warning now to reduce the amount of clutter.
>
> FWIW, I've reviewed the driver and found a few oddities, but nothing
> that needs to be fixed or that would be architecture specific.
In principle I don't disagree. However this warning was a specific
request of the driver writers. Since the driver is pretty much dead,
I'm not sure anyone is going to check or fix it for non-intel any time
soon.
James
next prev parent reply other threads:[~2015-05-19 13:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 13:33 [PATCH] [RESEND] SCSI: ips: remove pointless #warning Arnd Bergmann
2015-05-19 13:33 ` Arnd Bergmann
2015-05-19 13:52 ` James Bottomley [this message]
2015-05-19 13:52 ` James Bottomley
2015-05-19 13:56 ` Arnd Bergmann
2015-05-19 13:56 ` Arnd Bergmann
2015-05-19 18:38 ` James Bottomley
2015-05-19 18:38 ` James Bottomley
2015-05-19 18:42 ` Arnd Bergmann
2015-05-19 18:42 ` Arnd Bergmann
2015-05-19 19:25 ` Joe Perches
2015-05-19 19:25 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432043572.3007.14.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.