From: Oliver Neukum <oneukum@suse.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Laura Abbott <labbott@redhat.com>,
Marcel Holtmann <marcel@holtmann.org>,
Laura Abbott <labbott@fedoraproject.org>,
"Gustavo F. Padovan" <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"bluez mailin list (linux-bluetooth@vger.kernel.org)"
<linux-bluetooth@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ming Lei <ming.lei@canonical.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-usb@vger.kernel.org
Subject: Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable
Date: Tue, 19 May 2015 19:42:55 +0200 [thread overview]
Message-ID: <1432057375.3970.4.camel@suse.com> (raw)
In-Reply-To: <s5hpp5wtrrp.wl-tiwai@suse.de>
On Tue, 2015-05-19 at 19:13 +0200, Takashi Iwai wrote:
> At Tue, 19 May 2015 10:26:46 -0400 (EDT),
> Alan Stern wrote:
> >
> > > > > Of just have request_firmware()
> > > > > actually sleep until userspace is ready. Seriously, why is
> > > > > request_firmware not just sleeping for us.
> >
> > It won't work. The request_firmware call is part of the probe
> > sequence, which in turn is part of the resume sequence. Userspace
> > doesn't start running again until the resume sequence is finished. If
> > request_firmware waited for userspace, it would hang.
>
> Note that the recent request_firmware() doesn't need the user-space
> invocation (unless the fallback is explicitly enabled) but loads the
That is a dangerous approach. You cannot be sure you can do file IO.
It depends on the exact shape of the device tree.
> file directly. And, request_firmware() for the cached data is valid
> to be called in the resume path.
Well, yes, if your data is cached in RAM, all is well. But that leads
to the same problem one step further. What must be cached?
Regards
Oliver
next prev parent reply other threads:[~2015-05-19 17:42 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 0:52 [RESEND][PATCH] Bluetooth: Make request workqueue freezable Laura Abbott
2015-05-12 1:07 ` Marcel Holtmann
2015-05-12 1:46 ` Laura Abbott
2015-05-12 15:14 ` Marcel Holtmann
2015-05-13 1:18 ` Laura Abbott
2015-05-19 9:46 ` Takashi Iwai
2015-05-19 9:46 ` Takashi Iwai
2015-05-19 14:26 ` Alan Stern
2015-05-19 14:52 ` Oliver Neukum
2015-05-19 15:22 ` Marcel Holtmann
2015-05-19 17:17 ` Alan Stern
2015-05-19 17:13 ` Takashi Iwai
2015-05-19 17:42 ` Oliver Neukum [this message]
2015-05-20 6:29 ` Takashi Iwai
2015-05-20 6:29 ` Takashi Iwai
2015-05-20 8:40 ` Oliver Neukum
2015-05-20 9:46 ` Marcel Holtmann
2015-05-20 12:44 ` Takashi Iwai
2015-05-20 23:42 ` Laura Abbott
2015-05-21 4:21 ` Takashi Iwai
2015-05-21 12:07 ` Marcel Holtmann
2015-05-21 12:36 ` Takashi Iwai
2015-05-21 14:18 ` Alan Stern
2015-05-21 14:39 ` Marcel Holtmann
2015-05-21 15:26 ` Alan Stern
2015-05-21 15:26 ` Alan Stern
2015-05-21 15:35 ` Takashi Iwai
2015-05-21 17:27 ` Arend van Spriel
2015-05-21 17:27 ` Arend van Spriel
2015-05-21 17:32 ` Takashi Iwai
2015-05-21 20:46 ` Arend van Spriel
2015-05-22 11:30 ` Oliver Neukum
2015-05-22 11:30 ` Oliver Neukum
2015-05-21 17:37 ` Alan Stern
2015-05-21 17:37 ` Alan Stern
2015-05-21 18:11 ` Takashi Iwai
2015-05-21 18:17 ` Laura Abbott
2015-05-22 0:21 ` Laura Abbott
2015-05-22 3:13 ` Marcel Holtmann
2015-05-22 3:13 ` Marcel Holtmann
2015-05-28 0:47 ` Laura Abbott
2015-06-02 1:14 ` [PATCH 1/2] Bluetooth: Add reset_resume function Laura Abbott
2015-06-02 1:14 ` Laura Abbott
2015-06-02 1:28 ` Marcel Holtmann
2015-06-02 1:28 ` Marcel Holtmann
2015-06-02 14:17 ` Josh Boyer
2015-06-02 14:17 ` Josh Boyer
2015-06-02 15:07 ` Marcel Holtmann
2015-06-02 15:07 ` Marcel Holtmann
2015-06-02 7:47 ` Oliver Neukum
2015-06-02 1:14 ` [PATCH 2/2] Bluetooth: btusb: " Laura Abbott
2015-06-02 1:14 ` Laura Abbott
2015-06-02 1:32 ` Marcel Holtmann
2015-06-02 1:32 ` Marcel Holtmann
2015-05-22 7:37 ` [RESEND][PATCH] Bluetooth: Make request workqueue freezable Arend van Spriel
2015-05-22 7:37 ` Arend van Spriel
2015-05-22 7:41 ` Arend van Spriel
2015-05-21 15:04 ` Takashi Iwai
2015-05-20 10:02 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432057375.3970.4.camel@suse.com \
--to=oneukum@suse.com \
--cc=davem@davemloft.net \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=labbott@fedoraproject.org \
--cc=labbott@redhat.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.