All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Liao <jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Matthias Brugger
	<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Mike Turquette
	<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	srv_heupstream
	<srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
	Ricky Liang <jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	"open list:OPEN FIRMWARE AND..."
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 4/5] clk: mediatek: Add subsystem clocks of MT8173
Date: Fri, 22 May 2015 14:03:10 +0800	[thread overview]
Message-ID: <1432274590.14396.40.camel@mtksdaap41> (raw)
In-Reply-To: <CAGS+omBgbj=Hx57GhxsQiuTR8Cx=hu0j4ptUh3GkScA81r42=A@mail.gmail.com>

Hi Daniel,

On Fri, 2015-05-22 at 12:22 +0800, Daniel Kurtz wrote:
> On Thu, May 21, 2015 at 3:12 PM, James Liao <jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
> > Most multimedia subsystem clocks will be accessed by multiple
> > drivers, so it's a better way to manage these clocks in CCF.
> > This patch adds clock support for MM, IMG, VDEC, VENC and VENC_LT
> > subsystems.
> 
> Is there a reason why this patch (or patch set) does not also include
> definitions for the SCP_SYS, AUDIO and MFG_SYS clocks?

Clocks of SCP_SYS is a workaround in our previous internal
implementation. It should be replaced with new mtk-scpsys driver which
implemented in pm_domain framework because they are used to power on/off
subsystem domains.

I had discussed with Sascha, and he said it not worth the overhead of
CCF for clocks that are not shared by different units. As I know AUDIO
and MFG clocks are only used by their own drivers. So I don't include
them in this patch.


Best regards,

James


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: jamesjj.liao@mediatek.com (James Liao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] clk: mediatek: Add subsystem clocks of MT8173
Date: Fri, 22 May 2015 14:03:10 +0800	[thread overview]
Message-ID: <1432274590.14396.40.camel@mtksdaap41> (raw)
In-Reply-To: <CAGS+omBgbj=Hx57GhxsQiuTR8Cx=hu0j4ptUh3GkScA81r42=A@mail.gmail.com>

Hi Daniel,

On Fri, 2015-05-22 at 12:22 +0800, Daniel Kurtz wrote:
> On Thu, May 21, 2015 at 3:12 PM, James Liao <jamesjj.liao@mediatek.com> wrote:
> > Most multimedia subsystem clocks will be accessed by multiple
> > drivers, so it's a better way to manage these clocks in CCF.
> > This patch adds clock support for MM, IMG, VDEC, VENC and VENC_LT
> > subsystems.
> 
> Is there a reason why this patch (or patch set) does not also include
> definitions for the SCP_SYS, AUDIO and MFG_SYS clocks?

Clocks of SCP_SYS is a workaround in our previous internal
implementation. It should be replaced with new mtk-scpsys driver which
implemented in pm_domain framework because they are used to power on/off
subsystem domains.

I had discussed with Sascha, and he said it not worth the overhead of
CCF for clocks that are not shared by different units. As I know AUDIO
and MFG clocks are only used by their own drivers. So I don't include
them in this patch.


Best regards,

James

WARNING: multiple messages have this Message-ID (diff)
From: James Liao <jamesjj.liao@mediatek.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Mike Turquette <mturquette@linaro.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	Ricky Liang <jcliang@chromium.org>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 4/5] clk: mediatek: Add subsystem clocks of MT8173
Date: Fri, 22 May 2015 14:03:10 +0800	[thread overview]
Message-ID: <1432274590.14396.40.camel@mtksdaap41> (raw)
In-Reply-To: <CAGS+omBgbj=Hx57GhxsQiuTR8Cx=hu0j4ptUh3GkScA81r42=A@mail.gmail.com>

Hi Daniel,

On Fri, 2015-05-22 at 12:22 +0800, Daniel Kurtz wrote:
> On Thu, May 21, 2015 at 3:12 PM, James Liao <jamesjj.liao@mediatek.com> wrote:
> > Most multimedia subsystem clocks will be accessed by multiple
> > drivers, so it's a better way to manage these clocks in CCF.
> > This patch adds clock support for MM, IMG, VDEC, VENC and VENC_LT
> > subsystems.
> 
> Is there a reason why this patch (or patch set) does not also include
> definitions for the SCP_SYS, AUDIO and MFG_SYS clocks?

Clocks of SCP_SYS is a workaround in our previous internal
implementation. It should be replaced with new mtk-scpsys driver which
implemented in pm_domain framework because they are used to power on/off
subsystem domains.

I had discussed with Sascha, and he said it not worth the overhead of
CCF for clocks that are not shared by different units. As I know AUDIO
and MFG clocks are only used by their own drivers. So I don't include
them in this patch.


Best regards,

James



  reply	other threads:[~2015-05-22  6:03 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21  7:12 [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support James Liao
2015-05-21  7:12 ` James Liao
2015-05-21  7:12 ` James Liao
     [not found] ` <1432192376-6712-1-git-send-email-jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-05-21  7:12   ` [PATCH 1/5] clk: mediatek: Fix apmixedsys clock registration James Liao
2015-05-21  7:12     ` James Liao
2015-05-21  7:12     ` James Liao
2015-05-26  7:42     ` Sascha Hauer
2015-05-26  7:42       ` Sascha Hauer
2015-06-04 21:07     ` Stephen Boyd
2015-06-04 21:07       ` Stephen Boyd
2015-05-21  7:12 ` [PATCH 2/5] clk: mediatek: mt8173: Fix enabling of critical clocks James Liao
2015-05-21  7:12   ` James Liao
2015-05-21  7:12   ` James Liao
2015-05-26  7:46   ` Sascha Hauer
2015-05-26  7:46     ` Sascha Hauer
     [not found]     ` <20150526074608.GE6325-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-05-26  8:36       ` James Liao
2015-05-26  8:36         ` James Liao
2015-05-26  8:36         ` James Liao
2015-05-21  7:12 ` [PATCH 3/5] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers James Liao
2015-05-21  7:12   ` James Liao
2015-05-21  7:12   ` James Liao
     [not found]   ` <1432192376-6712-4-git-send-email-jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-05-26  7:56     ` Sascha Hauer
2015-05-26  7:56       ` Sascha Hauer
2015-05-26  7:56       ` Sascha Hauer
     [not found]       ` <20150526075643.GF6325-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-05-26  8:55         ` James Liao
2015-05-26  8:55           ` James Liao
2015-05-26  8:55           ` James Liao
2015-05-26 11:08           ` Sascha Hauer
2015-05-26 11:08             ` Sascha Hauer
2015-05-26 11:08             ` Sascha Hauer
2015-05-27  6:12             ` Yong Wu
2015-05-27  6:12               ` Yong Wu
2015-05-27  6:12               ` Yong Wu
2015-05-27  7:27               ` Sascha Hauer
2015-05-27  7:27                 ` Sascha Hauer
     [not found]                 ` <20150527072759.GS6325-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-05-28  5:14                   ` Yong Wu
2015-05-28  5:14                     ` Yong Wu
2015-05-28  5:14                     ` Yong Wu
2015-05-21  7:12 ` [PATCH 4/5] clk: mediatek: Add subsystem clocks of MT8173 James Liao
2015-05-21  7:12   ` James Liao
2015-05-21  7:12   ` James Liao
     [not found]   ` <1432192376-6712-5-git-send-email-jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-05-22  4:22     ` Daniel Kurtz
2015-05-22  4:22       ` Daniel Kurtz
2015-05-22  4:22       ` Daniel Kurtz
2015-05-22  6:03       ` James Liao [this message]
2015-05-22  6:03         ` James Liao
2015-05-22  6:03         ` James Liao
2015-06-12 17:09     ` Matthias Brugger
2015-06-12 17:09       ` Matthias Brugger
2015-06-12 17:09       ` Matthias Brugger
2015-06-15  2:10       ` James Liao
2015-06-15  2:10         ` James Liao
2015-06-15  2:10         ` James Liao
2015-05-21  7:12 ` [PATCH 5/5] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS James Liao
2015-05-21  7:12   ` James Liao
2015-05-21  7:12   ` James Liao
     [not found]   ` <1432192376-6712-6-git-send-email-jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-05-26  8:05     ` Sascha Hauer
2015-05-26  8:05       ` Sascha Hauer
2015-05-26  8:05       ` Sascha Hauer
     [not found]       ` <20150526080516.GG6325-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-05-26  9:11         ` James Liao
2015-05-26  9:11           ` James Liao
2015-05-26  9:11           ` James Liao
2015-05-26  9:41           ` Sascha Hauer
2015-05-26  9:41             ` Sascha Hauer
2015-05-26  9:41             ` Sascha Hauer
     [not found]             ` <20150526094140.GH6325-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-05-26  9:58               ` James Liao
2015-05-26  9:58                 ` James Liao
2015-05-26  9:58                 ` James Liao
2015-05-28 13:24 ` [PATCH 0/5] Add Mediatek MT8173 subsystem clocks support Sascha Hauer
2015-05-28 13:24   ` Sascha Hauer
     [not found]   ` <20150528132452.GI26575-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-05-29  2:47     ` James Liao
2015-05-29  2:47       ` James Liao
2015-05-29  2:47       ` James Liao
2015-05-29  6:23       ` Sascha Hauer
2015-05-29  6:23         ` Sascha Hauer
2015-05-29  6:23         ` Sascha Hauer
     [not found]         ` <20150529062345.GY6325-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-06-04 21:02           ` Stephen Boyd
2015-06-04 21:02             ` Stephen Boyd
2015-06-04 21:02             ` Stephen Boyd
     [not found]             ` <20150604210212.GM676-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-06-05  1:45               ` James Liao
2015-06-05  1:45                 ` James Liao
2015-06-05  1:45                 ` James Liao
2015-06-06  0:59                 ` Stephen Boyd
2015-06-06  0:59                   ` Stephen Boyd
     [not found]                   ` <20150606005912.GC29237-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-06-08  7:27                     ` James Liao
2015-06-08  7:27                       ` James Liao
2015-06-08  7:27                       ` James Liao
2015-06-08  7:48                     ` Sascha Hauer
2015-06-08  7:48                       ` Sascha Hauer
2015-06-08  7:48                       ` Sascha Hauer
     [not found]                       ` <20150608074858.GK6325-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-06-11 23:52                         ` Stephen Boyd
2015-06-11 23:52                           ` Stephen Boyd
2015-06-11 23:52                           ` Stephen Boyd
     [not found]                           ` <20150611235212.GI29640-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-06-12 17:05                             ` Matthias Brugger
2015-06-12 17:05                               ` Matthias Brugger
2015-06-12 17:05                               ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432274590.14396.40.camel@mtksdaap41 \
    --to=jamesjj.liao-nus5lvnupcjwk0htik3j/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.