* [PATCH] ASoC: max98925: Fix mask for setting DAI invert mode
@ 2015-05-26 12:35 Axel Lin
2015-05-26 17:32 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2015-05-26 12:35 UTC (permalink / raw)
To: Mark Brown
Cc: Anish kumar, alsa-devel@alsa-project.org, Ralph Birt,
Liam Girdwood
The M98925_DAI_WCI_MASK bit is not updated with current code.
To properly set the DAI invert mode, the mask should be
M98925_DAI_BCI_MASK | M98925_DAI_WCI_MASK.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/max98925.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/max98925.c b/sound/soc/codecs/max98925.c
index 9b5a17d..aad6642 100644
--- a/sound/soc/codecs/max98925.c
+++ b/sound/soc/codecs/max98925.c
@@ -346,7 +346,7 @@ static int max98925_dai_set_fmt(struct snd_soc_dai *codec_dai,
}
regmap_update_bits(max98925->regmap, MAX98925_FORMAT,
- M98925_DAI_BCI_MASK, invert);
+ M98925_DAI_BCI_MASK | M98925_DAI_WCI_MASK, invert);
return 0;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: max98925: Fix mask for setting DAI invert mode
2015-05-26 12:35 [PATCH] ASoC: max98925: Fix mask for setting DAI invert mode Axel Lin
@ 2015-05-26 17:32 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2015-05-26 17:32 UTC (permalink / raw)
To: Axel Lin
Cc: Anish kumar, alsa-devel@alsa-project.org, Ralph Birt,
Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 243 bytes --]
On Tue, May 26, 2015 at 08:35:08PM +0800, Axel Lin wrote:
> The M98925_DAI_WCI_MASK bit is not updated with current code.
> To properly set the DAI invert mode, the mask should be
> M98925_DAI_BCI_MASK | M98925_DAI_WCI_MASK.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-26 17:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-26 12:35 [PATCH] ASoC: max98925: Fix mask for setting DAI invert mode Axel Lin
2015-05-26 17:32 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.