[PATCH] tests/data: Add log parsing test code

[PATCH] tests/data: Add log parsing test code

[Richard Purdie]

This allows us to write tests which ensure a particular action generates
a particular log message.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/bitbake/lib/bb/tests/data.py b/bitbake/lib/bb/tests/data.py
index 7994a88..6ed80fb 100644
--- a/bitbake/lib/bb/tests/data.py
+++ b/bitbake/lib/bb/tests/data.py
@@ -25,6 +25,28 @@ import bb
 import bb.data
 import bb.parse
 
+class LogRecord():
+    def __enter__(self):
+        import logging
+        logs = []
+        class LogHandler(logging.Handler):
+            def emit(self, record):
+                logs.append(record)
+
+        logger = logging.getLogger("BitBake")
+        handler = LogHandler()
+        logger.addHandler(handler)
+        return logs
+    def __exit__(self, type, value, traceback):
+        return
+
+def LogContains(item, logs):
+    for l in logs:
+        m = l.getMessage()
+        if item in m:
+            return True
+    return False
+
 class DataExpansions(unittest.TestCase):
     def setUp(self):
         self.d = bb.data.init()

Re: [PATCH] tests/data: Add log parsing test code

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

On Tue, May 26, 2015 at 8:17 AM, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> +class LogRecord():
> +    def __enter__(self):
> +        import logging
> +        logs = []
> +        class LogHandler(logging.Handler):
> +            def emit(self, record):
> +                logs.append(record)
> +
> +        logger = logging.getLogger("BitBake")
> +        handler = LogHandler()
> +        logger.addHandler(handler)
> +        return logs
> +    def __exit__(self, type, value, traceback):
> +        return
>

I realize it probably doesn’t matter in the testing case specifically, but
this lies to the user of the class. Using a context manager that doesn’t
undo what it’s done on exit.. :)
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1463 bytes --]

Re: [PATCH] tests/data: Add log parsing test code

[Richard Purdie]

On Tue, 2015-05-26 at 08:26 -0700, Christopher Larson wrote:
> 
> On Tue, May 26, 2015 at 8:17 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>         +class LogRecord():
>         +    def __enter__(self):
>         +        import logging
>         +        logs = []
>         +        class LogHandler(logging.Handler):
>         +            def emit(self, record):
>         +                logs.append(record)
>         +
>         +        logger = logging.getLogger("BitBake")
>         +        handler = LogHandler()
>         +        logger.addHandler(handler)
>         +        return logs
>         +    def __exit__(self, type, value, traceback):
>         +        return
> 
> I realize it probably doesn’t matter in the testing case specifically,
> but this lies to the user of the class. Using a context manager that
> doesn’t undo what it’s done on exit.. :)

Er, yes, quite. I knew there was something I'd meant to go back and do
once it worked. I've posted a v2 with that fixed.

Cheers,

Richard

Re: [PATCH] tests/data: Add log parsing test code

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

On Tue, May 26, 2015 at 8:17 AM, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> +def LogContains(item, logs):
> +    for l in logs:
> +        m = l.getMessage()
> +        if item in m:
> +            return True
> +    return False
>

I didn’t notice at first, but this doesn’t comply with PEP8 — camelcase is
for use with class names, not function names. Minor, obviously :)
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 998 bytes --]