From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Narsimhulu Musini <nmusini@cisco.com>
Cc: linux-scsi@vger.kernel.org, hare@suse.de,
Sesidhar Baddela <sebaddel@cisco.com>
Subject: Re: [PATCH v6 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS
Date: Thu, 28 May 2015 06:55:16 -0700 [thread overview]
Message-ID: <1432821316.2199.14.camel@HansenPartnership.com> (raw)
In-Reply-To: <1432711182-17530-10-git-send-email-nmusini@cisco.com>
In general, patch is much better: it passes all the static checker tests
for byte width and endianness issues. However
On Wed, 2015-05-27 at 00:19 -0700, Narsimhulu Musini wrote:
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 9c92f41..8baab3f 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -634,6 +634,23 @@ config FCOE_FNIC
> <file:Documentation/scsi/scsi.txt>.
> The module will be called fnic.
>
> +config SCSI_SNIC
> + tristate "Cisco SNIC Driver"
> + depends on PCI && SCSI && X86_64
Please don't restrict the compilation architecture in the Kconfig
because that restricts the amount of build testing the driver gets.
Instead you can put a runtime warning in the driver if you insist.
Something like this
http://thread.gmane.org/gmane.linux.scsi/101846
Where you add a runtime taint is much better.
James
next prev parent reply other threads:[~2015-05-28 13:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 7:19 [PATCH v6 0/9] snic:initial submission of snic driver for Cisco SCSI HBA Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 1/9] snic: snic module infrastructure Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 2/9] snic:Add interrupt, resource firmware interfaces Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 3/9] snic:Add meta request, handling of meta requests Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 4/9] snic:Add snic target discovery Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 5/9] snic:add SCSI handling, AEN, and fwreset handling Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 6/9] snic:Add low level queuing interfaces Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 7/9] snic:Add sysfs entries to list stats and trace data Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 8/9] snic:Add event tracing to capture IO events Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS Narsimhulu Musini
2015-05-27 9:17 ` Boaz Harrosh
2015-05-27 10:02 ` Narsimhulu Musini (nmusini)
2015-05-27 11:25 ` Boaz Harrosh
2015-05-28 9:49 ` Narsimhulu Musini (nmusini)
2015-05-28 13:42 ` Johannes Thumshirn
2015-05-28 17:59 ` Narsimhulu Musini (nmusini)
2015-05-28 13:55 ` James Bottomley [this message]
2015-05-28 18:01 ` Narsimhulu Musini (nmusini)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432821316.2199.14.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=nmusini@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.