From: Boaz Harrosh <boaz@plexistor.com>
To: Narsimhulu Musini <nmusini@cisco.com>,
James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, hare@suse.de
Cc: Sesidhar Baddela <sebaddel@cisco.com>
Subject: Re: [PATCH v6 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS
Date: Wed, 27 May 2015 12:17:32 +0300 [thread overview]
Message-ID: <55658BAC.5000009@plexistor.com> (raw)
In-Reply-To: <1432711182-17530-10-git-send-email-nmusini@cisco.com>
On 05/27/2015 10:19 AM, Narsimhulu Musini wrote:
> Kconfig for kbuild
> Makefile to build snic module
>
> Updated MAINTAINERS file
>
> Signed-off-by: Narsimhulu Musini <nmusini@cisco.com>
> Signed-off-by: Sesidhar Baddela <sebaddel@cisco.com>
> ---
> * v3
> - Added additional config section (CONFIG_SNIC_DEBUG_FS) for enabling debugging
> functionality.
>
> * v2
> - Added compile time flags for debugfs dependent functionality.
>
> MAINTAINERS | 7 +++++++
> drivers/scsi/Kconfig | 17 +++++++++++++++++
> drivers/scsi/Makefile | 1 +
> drivers/scsi/snic/Makefile | 21 +++++++++++++++++++++
> 4 files changed, 46 insertions(+)
> create mode 100644 drivers/scsi/snic/Makefile
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2a97e05..368fb76 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2536,6 +2536,13 @@ L: linux-scsi@vger.kernel.org
> S: Supported
> F: drivers/scsi/fnic/
>
> +CISCO SCSI HBA DRIVER
> +M: Narsimhulu Musini <nmusini@cisco.com>
> +M: Sesidhar Baddela <sebaddel@cisco.com>
> +L: linux-scsi@vger.kernel.org
> +S: Supported
> +F: drivers/scsi/snic/
> +
> CMPC ACPI DRIVER
> M: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
> M: Daniel Oliveira Nascimento <don@syst.com.br>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 9c92f41..8baab3f 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -634,6 +634,23 @@ config FCOE_FNIC
> <file:Documentation/scsi/scsi.txt>.
> The module will be called fnic.
>
> +config SCSI_SNIC
> + tristate "Cisco SNIC Driver"
> + depends on PCI && SCSI && X86_64
> + help
> + This is support for the Cisco PCI-Express SCSI HBA.
> +
> + To compile this driver as a module, choose M here and read
> + <file:Documentation/scsi/scsi.txt>.
> + The module will be called snic.
> +
> +config SCSI_SNIC_DEBUG_FS
> + bool "Cisco SNIC Driver Debugfs Support"
> + depends on SCSI_SNIC && DEBUG_FS
> + help
> + This enables to list debugging information from SNIC Driver
> + available via debugfs file system
> +
> config SCSI_DMX3191D
> tristate "DMX3191D SCSI support"
> depends on PCI && SCSI
> diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
> index 58158f1..f643942 100644
> --- a/drivers/scsi/Makefile
> +++ b/drivers/scsi/Makefile
> @@ -39,6 +39,7 @@ obj-$(CONFIG_LIBFC) += libfc/
> obj-$(CONFIG_LIBFCOE) += fcoe/
> obj-$(CONFIG_FCOE) += fcoe/
> obj-$(CONFIG_FCOE_FNIC) += fnic/
> +obj-$(CONFIG_SCSI_SNIC) += snic/
> obj-$(CONFIG_SCSI_BNX2X_FCOE) += libfc/ fcoe/ bnx2fc/
> obj-$(CONFIG_ISCSI_TCP) += libiscsi.o libiscsi_tcp.o iscsi_tcp.o
> obj-$(CONFIG_INFINIBAND_ISER) += libiscsi.o
> diff --git a/drivers/scsi/snic/Makefile b/drivers/scsi/snic/Makefile
> new file mode 100644
> index 0000000..572102a
> --- /dev/null
> +++ b/drivers/scsi/snic/Makefile
> @@ -0,0 +1,21 @@
> +obj-$(CONFIG_SCSI_SNIC) += snic.o
> +
> +snic-y := \
> + snic_attrs.o \
> + snic_main.o \
> + snic_res.o \
> + snic_isr.o \
> + snic_ctl.o \
> + snic_io.o \
> + snic_scsi.o \
> + snic_disc.o \
> + vnic_cq.o \
> + vnic_intr.o \
> + vnic_dev.o \
> + vnic_wq.o
> +
> +ifeq ($(CONFIG_SCSI_SNIC_DEBUG_FS), y)
> +ccflags-y += -DSNIC_DEBUG_FS
Why do you need an extra define here just use
CONFIG_SCSI_SNIC_DEBUG_FS in source code directly
> +snic-y += snic_debugfs.o \
> + snic_trc.o
> +endif
>
snic-$(CONFIG_SCSI_SNIC_DEBUG_FS) += snic_debugfs.o
You do not the ifeq () thing at all
Cheers
Boaz
next prev parent reply other threads:[~2015-05-27 9:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 7:19 [PATCH v6 0/9] snic:initial submission of snic driver for Cisco SCSI HBA Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 1/9] snic: snic module infrastructure Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 2/9] snic:Add interrupt, resource firmware interfaces Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 3/9] snic:Add meta request, handling of meta requests Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 4/9] snic:Add snic target discovery Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 5/9] snic:add SCSI handling, AEN, and fwreset handling Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 6/9] snic:Add low level queuing interfaces Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 7/9] snic:Add sysfs entries to list stats and trace data Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 8/9] snic:Add event tracing to capture IO events Narsimhulu Musini
2015-05-27 7:19 ` [PATCH v6 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS Narsimhulu Musini
2015-05-27 9:17 ` Boaz Harrosh [this message]
2015-05-27 10:02 ` Narsimhulu Musini (nmusini)
2015-05-27 11:25 ` Boaz Harrosh
2015-05-28 9:49 ` Narsimhulu Musini (nmusini)
2015-05-28 13:42 ` Johannes Thumshirn
2015-05-28 17:59 ` Narsimhulu Musini (nmusini)
2015-05-28 13:55 ` James Bottomley
2015-05-28 18:01 ` Narsimhulu Musini (nmusini)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55658BAC.5000009@plexistor.com \
--to=boaz@plexistor.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=nmusini@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.