From: Ian Campbell <ian.campbell@citrix.com>
To: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com,
andrew.cooper3@citrix.com, yunhong.jiang@intel.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
rshriram@cs.ubc.ca
Subject: Re: [PATCH v1 2/5] tools/libxl: move domain suspend codes into a separate file
Date: Tue, 2 Jun 2015 15:45:19 +0100 [thread overview]
Message-ID: <1433256319.15036.292.camel@citrix.com> (raw)
In-Reply-To: <1432116090-19486-3-git-send-email-yanghy@cn.fujitsu.com>
On Wed, 2015-05-20 at 18:01 +0800, Yang Hongyang wrote:
> diff --git a/tools/libxl/libxl_internal.h
> b/tools/libxl/libxl_internal.h
> index f86fc89..b2eeb89 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -3191,6 +3191,12 @@ _hidden void
> libxl__domain_save_device_model(libxl__egc *egc,
>
> _hidden const char *libxl__device_model_savefile(libxl__gc *gc,
> uint32_t domid);
>
> +void libxl__domain_suspend_callback(void *data);
> +
> +/* calls dss->callback_common_done when done */
> +void libxl__domain_suspend(libxl__egc *egc,
> + libxl__domain_suspend_state *dss);
Please mark these internal functions _hidden like the other examples in
this file.
With that the ack I just sent before I notice this stands.
Ian.
next prev parent reply other threads:[~2015-06-02 14:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 10:01 [PATCH v1 0/5] Misc cleanups for libxl Yang Hongyang
2015-05-20 10:01 ` [PATCH v1 1/5] libxl/save: Refactor libxl__domain_suspend_state Yang Hongyang
2015-06-02 14:40 ` Ian Campbell
2015-06-02 16:10 ` Yang Hongyang
2015-06-03 9:24 ` Ian Campbell
2015-06-03 9:50 ` Yang Hongyang
2015-06-03 10:03 ` Yang Hongyang
2015-05-20 10:01 ` [PATCH v1 2/5] tools/libxl: move domain suspend codes into a separate file Yang Hongyang
2015-06-02 14:44 ` Ian Campbell
2015-06-02 14:45 ` Ian Campbell [this message]
2015-06-02 16:10 ` Yang Hongyang
2015-05-20 10:01 ` [PATCH v1 3/5] tools/libxl: move remus codes into libxl_remus.c Yang Hongyang
2015-06-02 14:46 ` Ian Campbell
2015-06-02 16:13 ` Yang Hongyang
2015-05-20 10:01 ` [PATCH v1 4/5] tools/libxl: move toolstack code into libxl_toolstack.c Yang Hongyang
2015-06-02 14:48 ` Ian Campbell
2015-06-02 16:22 ` Yang Hongyang
2015-06-03 2:52 ` Yang Hongyang
2015-06-03 9:24 ` Ian Campbell
2015-05-20 10:01 ` [PATCH v1 5/5] tools/libxl: move domain save codes into libxl_dom_save.c Yang Hongyang
2015-05-27 8:30 ` [PATCH v1 0/5] Misc cleanups for libxl Yang Hongyang
2015-06-02 14:53 ` Ian Campbell
2015-06-02 16:25 ` Yang Hongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433256319.15036.292.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=wei.liu2@citrix.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.