From: Yang Hongyang <yanghy@cn.fujitsu.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com,
andrew.cooper3@citrix.com, yunhong.jiang@intel.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
rshriram@cs.ubc.ca
Subject: Re: [PATCH v1 4/5] tools/libxl: move toolstack code into libxl_toolstack.c
Date: Wed, 3 Jun 2015 00:22:25 +0800 [thread overview]
Message-ID: <556DD841.5030609@cn.fujitsu.com> (raw)
In-Reply-To: <1433256512.15036.296.camel@citrix.com>
On 06/02/2015 10:48 PM, Ian Campbell wrote:
> On Wed, 2015-05-20 at 18:01 +0800, Yang Hongyang wrote:
>> move toolstack code into libxl_toolstack.c
>
> It's not clear to me what "toolstack code" is here, the whole of libxl
> and xl is "toolstack code".
>
> Is the code being moved stuff to do with adding toolstack state to the
> save stream? Perhaps libxl_{suspend,save}_toolstack.c? Or could this not
> go in the libxl_dom_suspend.c you just created?
My thought was libxl_dom_suspend.c only contains code that do vm suspend
stuff(not save). So compare to move it to dom_suspend.c, I prefer not
move it or use libxl_{suspend,save}_toolstack.c. Maybe leave the code
not moved?
>
>
> .
>
--
Thanks,
Yang.
next prev parent reply other threads:[~2015-06-02 16:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 10:01 [PATCH v1 0/5] Misc cleanups for libxl Yang Hongyang
2015-05-20 10:01 ` [PATCH v1 1/5] libxl/save: Refactor libxl__domain_suspend_state Yang Hongyang
2015-06-02 14:40 ` Ian Campbell
2015-06-02 16:10 ` Yang Hongyang
2015-06-03 9:24 ` Ian Campbell
2015-06-03 9:50 ` Yang Hongyang
2015-06-03 10:03 ` Yang Hongyang
2015-05-20 10:01 ` [PATCH v1 2/5] tools/libxl: move domain suspend codes into a separate file Yang Hongyang
2015-06-02 14:44 ` Ian Campbell
2015-06-02 14:45 ` Ian Campbell
2015-06-02 16:10 ` Yang Hongyang
2015-05-20 10:01 ` [PATCH v1 3/5] tools/libxl: move remus codes into libxl_remus.c Yang Hongyang
2015-06-02 14:46 ` Ian Campbell
2015-06-02 16:13 ` Yang Hongyang
2015-05-20 10:01 ` [PATCH v1 4/5] tools/libxl: move toolstack code into libxl_toolstack.c Yang Hongyang
2015-06-02 14:48 ` Ian Campbell
2015-06-02 16:22 ` Yang Hongyang [this message]
2015-06-03 2:52 ` Yang Hongyang
2015-06-03 9:24 ` Ian Campbell
2015-05-20 10:01 ` [PATCH v1 5/5] tools/libxl: move domain save codes into libxl_dom_save.c Yang Hongyang
2015-05-27 8:30 ` [PATCH v1 0/5] Misc cleanups for libxl Yang Hongyang
2015-06-02 14:53 ` Ian Campbell
2015-06-02 16:25 ` Yang Hongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556DD841.5030609@cn.fujitsu.com \
--to=yanghy@cn.fujitsu.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=wei.liu2@citrix.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.