Patch "hwmon: (nct6683) Add missing sysfs attribute initialization" has been added to the 4.0-stable tree

Patch "hwmon: (nct6683) Add missing sysfs attribute initialization" has been added to the 4.0-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    hwmon: (nct6683) Add missing sysfs attribute initialization

to the 4.0-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     hwmon-nct6683-add-missing-sysfs-attribute-initialization.patch
and it can be found in the queue-4.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From c7bd6dc320b85445b6b36a0aff41f929210027c7 Mon Sep 17 00:00:00 2001
From: Guenter Roeck <linux@roeck-us.net>
Date: Thu, 28 May 2015 09:12:23 -0700
Subject: hwmon: (nct6683) Add missing sysfs attribute initialization

From: Guenter Roeck <linux@roeck-us.net>

commit c7bd6dc320b85445b6b36a0aff41f929210027c7 upstream.

The following error message is seen when loading the nct6683 driver
with DEBUG_LOCK_ALLOC enabled.

BUG: key ffff88040b2f0030 not in .data!
------------[ cut here ]------------
WARNING: CPU: 0 PID: 186 at kernel/locking/lockdep.c:2988
				lockdep_init_map+0x469/0x630()
DEBUG_LOCKS_WARN_ON(1)

Caused by a missing call to sysfs_attr_init() when initializing
sysfs attributes.

Reported-by: Alexey Orishko <alexey.orishko@gmail.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/hwmon/nct6683.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -439,6 +439,7 @@ nct6683_create_attr_group(struct device
 				 (*t)->dev_attr.attr.name, tg->base + i);
 			if ((*t)->s2) {
 				a2 = &su->u.a2;
+				sysfs_attr_init(&a2->dev_attr.attr);
 				a2->dev_attr.attr.name = su->name;
 				a2->nr = (*t)->u.s.nr + i;
 				a2->index = (*t)->u.s.index;
@@ -449,6 +450,7 @@ nct6683_create_attr_group(struct device
 				*attrs = &a2->dev_attr.attr;
 			} else {
 				a = &su->u.a1;
+				sysfs_attr_init(&a->dev_attr.attr);
 				a->dev_attr.attr.name = su->name;
 				a->index = (*t)->u.index + i;
 				a->dev_attr.attr.mode =


Patches currently in stable-queue which might be from linux@roeck-us.net are

queue-4.0/hwmon-ntc_thermistor-ensure-iio-channel-is-of-type-iio_voltage.patch
queue-4.0/hwmon-tmp401-do-not-auto-detect-chip-on-i2c-address-0x37.patch
queue-4.0/hwmon-nct6775-add-missing-sysfs-attribute-initialization.patch
queue-4.0/hwmon-nct6683-add-missing-sysfs-attribute-initialization.patch