All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hervé Poussineau" <hpoussin@reactos.org>
To: qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>,
	"Leon Alrae" <leon.alrae@imgtec.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH v3 05/16] dma/rc4030: document register at offset 0x210
Date: Wed,  3 Jun 2015 22:45:39 +0200	[thread overview]
Message-ID: <1433364350-19380-6-git-send-email-hpoussin@reactos.org> (raw)
In-Reply-To: <1433364350-19380-1-git-send-email-hpoussin@reactos.org>

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
---
 hw/dma/rc4030.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c
index 96f796b..bf82eed 100644
--- a/hw/dma/rc4030.c
+++ b/hw/dma/rc4030.c
@@ -86,7 +86,7 @@ typedef struct rc4030State
     uint32_t cache_bmask; /* 0x0058: I/O Cache Byte Mask */
 
     uint32_t nmi_interrupt; /* 0x0200: interrupt source */
-    uint32_t offset210;
+    uint32_t memory_refresh_rate; /* 0x0210: memory refresh rate */
     uint32_t nvram_protect; /* 0x0220: NV ram protect register */
     uint32_t rem_speed[16];
     uint32_t imr_jazz; /* Local bus int enable mask */
@@ -233,9 +233,9 @@ static uint64_t rc4030_read(void *opaque, hwaddr addr, unsigned int size)
     case 0x0208:
         val = 0;
         break;
-    /* Offset 0x0210 */
+    /* Memory refresh rate */
     case 0x0210:
-        val = s->offset210;
+        val = s->memory_refresh_rate;
         break;
     /* NV ram protect register */
     case 0x0220:
@@ -461,9 +461,9 @@ static void rc4030_write(void *opaque, hwaddr addr, uint64_t data,
             s->dma_regs[entry][idx] = val;
         }
         break;
-    /* Offset 0x0210 */
+    /* Memory refresh rate */
     case 0x0210:
-        s->offset210 = val;
+        s->memory_refresh_rate = val;
         break;
     /* Interval timer reload */
     case 0x0228:
@@ -621,7 +621,7 @@ static void rc4030_reset(void *opaque)
     s->cache_ptag = s->cache_ltag = 0;
     s->cache_bmask = 0;
 
-    s->offset210 = 0x18186;
+    s->memory_refresh_rate = 0x18186;
     s->nvram_protect = 7;
     for (i = 0; i < 15; i++)
         s->rem_speed[i] = 7;
@@ -655,7 +655,7 @@ static int rc4030_load(QEMUFile *f, void *opaque, int version_id)
     s->cache_ptag = qemu_get_be32(f);
     s->cache_ltag = qemu_get_be32(f);
     s->cache_bmask = qemu_get_be32(f);
-    s->offset210 = qemu_get_be32(f);
+    s->memory_refresh_rate = qemu_get_be32(f);
     s->nvram_protect = qemu_get_be32(f);
     for (i = 0; i < 15; i++)
         s->rem_speed[i] = qemu_get_be32(f);
@@ -687,7 +687,7 @@ static void rc4030_save(QEMUFile *f, void *opaque)
     qemu_put_be32(f, s->cache_ptag);
     qemu_put_be32(f, s->cache_ltag);
     qemu_put_be32(f, s->cache_bmask);
-    qemu_put_be32(f, s->offset210);
+    qemu_put_be32(f, s->memory_refresh_rate);
     qemu_put_be32(f, s->nvram_protect);
     for (i = 0; i < 15; i++)
         qemu_put_be32(f, s->rem_speed[i]);
-- 
2.1.4

  parent reply	other threads:[~2015-06-03 20:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 20:45 [Qemu-devel] [PATCH v3 00/16] net/dp8393x and dma/rc4030 improvements Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 01/16] mips jazz: compile only in 64 bit Hervé Poussineau
2015-06-03 21:00   ` Aurelien Jarno
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 02/16] dma/rc4030: create custom DMA address space Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 03/16] dma/rc4030: use AddressSpace and address_space_rw in users Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 04/16] dma/rc4030: do not use old_mmio accesses Hervé Poussineau
2015-06-03 20:45 ` Hervé Poussineau [this message]
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 06/16] dma/rc4030: use trace events instead of custom logging Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 07/16] dma/rc4030: convert to QOM Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 08/16] net/dp8393x: always calculate proper checksums Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 09/16] net/dp8393x: do not use old_mmio accesses Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 10/16] net/dp8393x: use dp8393x_ prefix for all functions Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 11/16] net/dp8393x: QOM'ify Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 12/16] net/dp8393x: add PROM to store MAC address Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 13/16] net/dp8393x: add load/save support Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 14/16] net/dp8393x: correctly reset in_use field Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 15/16] net/dp8393x: fix hardware reset Hervé Poussineau
2015-06-03 20:45 ` [Qemu-devel] [PATCH v3 16/16] [RFC] dma/rc4030: do multiple calls to address_space_rw when doing DMA transfers Hervé Poussineau
2015-06-10 12:00   ` Leon Alrae
2015-06-10 19:37     ` Hervé Poussineau
2015-06-10 20:20       ` Peter Maydell
2015-06-10 20:22       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433364350-19380-6-git-send-email-hpoussin@reactos.org \
    --to=hpoussin@reactos.org \
    --cc=aurelien@aurel32.net \
    --cc=leon.alrae@imgtec.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.