Re: [block] fbccf1df065: +276.3% boot-meminfo.KernelStack

[Ming Lin <mlin@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2705 bytes --]

On Thu, 2015-06-04 at 08:49 +0800, huang ying wrote:
> Hi, Ming,
> 
> Here it is.
> 
> qemu-system-x86_64 -enable-kvm -cpu Haswell,+smep,+smap
> -kernel /pkg/linux/x86_64-lkp/gcc-4.9/fbccf1df06574add60bdb71103cc1662e477f02d/vmlinuz-4.1.0-rc4-00001-gfbccf1d -append 'root=/dev/ram0 user=lkp job=/lkp/scheduled/vm-kbuild-1G-15/bisect_boot-1-debian-x86_64-2015-02-07.cgz-x86_64-lkp-fbccf1df06574add60bdb71103cc1662e477f02d-1-20150529-44276-1cpbx2s.yaml ARCH=x86_64 kconfig=x86_64-lkp branch=linux-devel/devel-hourly-2015052515 commit=fbccf1df06574add60bdb71103cc1662e477f02d BOOT_IMAGE=/pkg/linux/x86_64-lkp/gcc-4.9/fbccf1df06574add60bdb71103cc1662e477f02d/vmlinuz-4.1.0-rc4-00001-gfbccf1d max_uptime=600 RESULT_ROOT=/result/boot/1/vm-kbuild-1G/debian-x86_64-2015-02-07.cgz/x86_64-lkp/gcc-4.9/fbccf1df06574add60bdb71103cc1662e477f02d/0 LKP_SERVER=inn earlyprintk=ttyS0,115200 systemd.log_level=err debug apic=debug sysrq_always_enabled rcupdate.rcu_cpu_stall_timeout=100 panic=-1 softlockup_panic=1 nmi_watchdog=panic oops=panic load_ramdisk=2 prompt_ramdisk=0 console=ttyS0,115200 console=tty0 vga=normal rw ip=::::vm-kbuild-1G-15::dhcp'  -initrd /fs/sda1/initrd-vm-kbuild-1G-15 -m 1024 -smp 2 -device e1000,netdev=net0 -netdev user,id=net0 -boot order=nc -no-reboot -watchdog i6300esb -rtc base=localtime -device virtio-scsi-pci,id=scsi0 -drive file=/fs/sda1/disk0-vm-kbuild-1G-15,if=none,id=hd0,media=disk,aio=native,cache=none -device scsi-hd,bus=scsi0.0,drive=hd0,scsi-id=1,lun=0 -drive file=/fs/sda1/disk1-vm-kbuild-1G-15,if=none,id=hd1,media=disk,aio=native,cache=none -device scsi-hd,bus=scsi0.0,drive=hd1,scsi-id=1,lun=1 -drive file=/fs/sda1/disk2-vm-kbuild-1G-15,if=none,id=hd2,media=disk,aio=native,cache=none -device scsi-hd,bus=scsi0.0,drive=hd2,scsi-id=1,lun=2 -drive file=/fs/sda1/disk3-vm-kbuild-1G-15,if=none,id=hd3,media=disk,aio=native,cache=none -device scsi-hd,bus=scsi0.0,drive=hd3,scsi-id=1,lun=3 -drive file=/fs/sda1/disk4-vm-kbuild-1G-15,if=none,id=hd4,media=disk,aio=native,cache=none -device scsi-hd,bus=scsi0.0,drive=hd4,scsi-id=1,lun=4 -pidfile /dev/shm/kboot/pid-vm-kbuild-1G-15 -serial file:/dev/shm/kboot/serial-vm-kbuild-1G-15 -daemonize -display none -monitor null

Here is the fix.
I'll merge it to patch "block: make generic_make_request handle
arbitrarily sized bios".

Thanks Ying.
> 
diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index 2b8fd30..feaeb12 100644
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -522,6 +522,8 @@ static void blk_release_queue(struct kobject *kobj)
 
 	blk_trace_shutdown(q);
 
+	bioset_free(q->bio_split);
+
 	ida_simple_remove(&blk_queue_ida, q->id);
 	call_rcu(&q->rcu_head, blk_free_queue_rcu);
 }