From: Joe Perches <joe@perches.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH 1/8] lib: string: Introduce strreplace
Date: Thu, 04 Jun 2015 15:45:47 -0700 [thread overview]
Message-ID: <1433457947.2658.9.camel@perches.com> (raw)
In-Reply-To: <20150604223753.GO7232@ZenIV.linux.org.uk>
On Thu, 2015-06-04 at 23:37 +0100, Al Viro wrote:
> On Thu, Jun 04, 2015 at 03:56:07AM -0700, Joe Perches wrote:
> > Seems sensible, but the name maybe could be be more
> > explicit as strreplace seems like it should more like
> > a string substitution rather than a char substitution.
> >
> > Maybe strsubstchr or something like it (strtranschr?)
>
> Why not go the full monty and call it strtrtsstrrrtst(), with
> strtrtssstrrtst() doing almost, but not quite the same thing?
Presumably the extra r is for reverse and the
extra s in for insensitive, just because...
Naming does matter. Consistency too.
And for the consistency bit, the char arguments
should probably be int.
next prev parent reply other threads:[~2015-06-04 22:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 9:37 [RFC/PATCH 0/8] Introduce strreplace Rasmus Villemoes
2015-06-04 9:37 ` [RFC/PATCH 1/8] lib: string: " Rasmus Villemoes
2015-06-04 10:56 ` Joe Perches
2015-06-04 22:37 ` Al Viro
2015-06-04 22:45 ` Joe Perches [this message]
2015-06-04 9:37 ` [RFC/PATCH 2/8] kernel/trace/trace_events_filter.c: Use strreplace Rasmus Villemoes
2015-06-08 15:49 ` Steven Rostedt
2015-06-04 9:37 ` [RFC/PATCH 3/8] blktrace: use strreplace in do_blk_trace_setup Rasmus Villemoes
2015-06-08 16:03 ` Steven Rostedt
2015-06-04 9:37 ` [RFC/PATCH 4/8] lib/kobject.c: Use strreplace Rasmus Villemoes
2015-06-04 21:56 ` Greg Kroah-Hartman
2015-06-04 22:31 ` Al Viro
2015-06-04 9:37 ` [RFC/PATCH 5/8] drivers/base/core.c: " Rasmus Villemoes
2015-06-04 21:56 ` Greg Kroah-Hartman
2015-06-04 22:28 ` Al Viro
2015-06-04 9:37 ` [RFC/PATCH 6/8] drivers/md/md.c: " Rasmus Villemoes
2015-06-04 9:37 ` [RFC/PATCH 7/8] fs/jbd2/journal.c: " Rasmus Villemoes
2015-06-04 9:37 ` [RFC/PATCH 8/8] fs/ext4/super.c: Use strreplace in ext4_fill_super Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433457947.2658.9.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=daniel@iogearbox.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.