All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Enric Balletbo i Serra
	<enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
	William wu <wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: USB3 regression in RK3399
Date: Wed, 21 Feb 2018 23:17:07 +0100	[thread overview]
Message-ID: <14336855.DpIqxNeK64@phil> (raw)
In-Reply-To: <CAAMcf8B5zpgbTsCu9t0rs9+jWkwRdO2C+KbF+NOt3ZTQx36aZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Vicente,

Am Mittwoch, 21. Februar 2018, 22:58:35 CET schrieb Vicente Bergas:
> testing on the Sapphire board, which uses the RK3399 SoC, a regression
> has been found in v4.16-rc2 wrt v4.15.4 regarding the USB3 type-A port:
> In v4.15.4 it works in USB2-only mode.
> In v4.16-rc2 it does not work.
> 
> It has been tested with a USB2 hub with 3 devices connected:
> a keyboard (USB1.1), a mouse (USB2) and a rtlwifi dongle (USB2).
> 
> It has also been tested with a USB3-to-SATA converter. This one is not
> working in v4.15.4 nor in v4.16-rc2.
> 
> I have also tried the 6-patch series from Enric Balletbo i Serra
> "[PATCH v3 3/6] phy: rockchip-typec: enable usb3 host during usb3 phy power on"
> with the same result.
> 
> During boot, the following message appears a few times:
> "dwc3: failed to initialize core"
> 
> The kernel configuration is:
> https://archlinuxarm.org/packages/aarch64/linux-aarch64-rc/files/config
> 
> Is that a configuration issue, a bug in the kernel or something else?
> If it is a configuration issue, what should be changed?
> If it is a bug, can it be fixed?

Hmm, I'd guess the main issue would be a missing typec-phy driver
in your kernel (see drivers/phy/rockchip/phy-rockchip-typec.c

But even with this driver, I realize that we'll be missing the extcon
driver telling the driver about the cable state. ChromeOS devices
get the cable-state from the embedded controller via the extcon
interface and while other boards seem to use the fusb302 chip
for power-delivery, the driver currently does not seem to
utilize the extcon interface for something like this.

Also, right now the rockchip typec-phy does fail probing when no
extcon is detected, but shouldn't it just fall back to working in host-
mode if it cannot get the extcon, or the device just routes everything
to a standard usb3 port?

Heiko

  parent reply	other threads:[~2018-02-21 22:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21 21:58 USB3 regression in RK3399 Vicente Bergas
     [not found] ` <CAAMcf8B5zpgbTsCu9t0rs9+jWkwRdO2C+KbF+NOt3ZTQx36aZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-21 22:17   ` Heiko Stuebner [this message]
2018-02-21 23:04     ` Vicente Bergas
     [not found]       ` <CAAMcf8B5ffH-5Q3+PcjWwu5UeDk4ESZR0BNczaED+vnPLwge0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-22  9:10         ` Enric Balletbo i Serra
     [not found]           ` <c8e1bd5a-19ff-9d1c-7e78-b7e605fd1e6b-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2018-02-22 20:30             ` Vicente Bergas
     [not found]               ` <CAAMcf8C7Px_mC=dex3TqejBNYYUyJxrZHa1c7CbKXj6g==Cbyg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-25 10:03                 ` Vicente Bergas
     [not found]                   ` <CAAMcf8DX4Mjuubnvwz9paMJ9oDYaNX-EKwFpsP9a-RfhHgO5Hg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-26 12:26                     ` Enric Balletbo i Serra
2018-02-26 16:34                     ` Enric Balletbo i Serra
     [not found]                       ` <9e64e878-07c8-912c-c597-7da7b3f96dd6-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2018-02-26 18:38                         ` Vicente Bergas
2018-09-08 19:00                         ` [PATCH 0/4] arm64: dts: Sapphire board: miscelaneous fixes Vicente Bergas
     [not found]                           ` <20180908190048.14231-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-08 19:00                             ` [PATCH 1/4] arm64: dts: Sapphire board: re-order vcc_sys Vicente Bergas
     [not found]                               ` <20180908190048.14231-2-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-10 12:15                                 ` Heiko Stuebner
2018-09-08 19:00                             ` [PATCH 2/4] arm64: dts: Sapphire board: Fix VCC5V0_HOST_EN Vicente Bergas
     [not found]                               ` <20180908190048.14231-3-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-10 12:16                                 ` Heiko Stuebner
2018-09-08 19:00                             ` [PATCH 3/4] arm64: dts: Sapphire board has DVS2 disabled Vicente Bergas
     [not found]                               ` <20180908190048.14231-4-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-10 12:17                                 ` Heiko Stuebner
2018-09-08 19:00                             ` [PATCH 4/4] arm64: dts: Sapphire board: Fix Type-C port supply Vicente Bergas
     [not found]                               ` <20180908190048.14231-5-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-10 12:23                                 ` Heiko Stuebner
2018-09-10 13:39                                   ` Vicente Bergas
     [not found]                                     ` <CAAMcf8Dr6Kfgx6aqy0vk9TBjW1=0sDp=zJAetjAt5AhPVwHDdA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-09-10 14:10                                       ` Heiko Stuebner
2018-09-10 16:10                                         ` [PATCH v2] arm64: dts: rockchip: Fix Type-C port supply in Sapphire board Vicente Bergas
     [not found]                                           ` <20180910161029.1948-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-10 17:19                                             ` Heiko Stuebner
2019-05-18 12:29                                               ` Vicente Bergas
     [not found]                                                 ` <574f2bae-0121-4cc7-ad9a-5ba32315d71b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-05-22 15:07                                                   ` [PATCH] arm64: rockchip: dts: sapphire: Fix USB3 Type-C Vicente Bergas
     [not found]                                                     ` <20190522150717.1748-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-14  9:47                                                       ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14336855.DpIqxNeK64@phil \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.