From: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Enric Balletbo i Serra
<enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
William wu <wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: [PATCH] arm64: rockchip: dts: sapphire: Fix USB3 Type-C.
Date: Wed, 22 May 2019 17:07:17 +0200 [thread overview]
Message-ID: <20190522150717.1748-1-vicencb@gmail.com> (raw)
In-Reply-To: <574f2bae-0121-4cc7-ad9a-5ba32315d71b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Before this patch, the Type-C port on the Sapphire board is dead.
Applying only the power supply part of this patch, makes the port work
for about 4 seconds at start-up. This is a sample trace with a memory
stick plugged in:
1.- The memory stick LED lights on and kernel reports:
[ 4.782999] scsi 0:0:0:0: Direct-Access USB DISK PMAP PQ: 0 ANSI: 4
[ 5.904580] sd 0:0:0:0: [sdb] 3913344 512-byte logical blocks: (2.00 GB/1.87 GiB)
[ 5.906860] sd 0:0:0:0: [sdb] Write Protect is off
[ 5.908973] sd 0:0:0:0: [sdb] Mode Sense: 23 00 00 00
[ 5.909122] sd 0:0:0:0: [sdb] No Caching mode page found
[ 5.911214] sd 0:0:0:0: [sdb] Assuming drive cache: write through
[ 5.951585] sdb: sdb1
[ 5.954816] sd 0:0:0:0: [sdb] Attached SCSI removable disk
2.- 4 seconds later the memory stick LED lights off and kernel reports:
[ 9.082822] phy phy-ff770000.syscon:usb2-phy@e450.2: charger = USB_DCP_CHARGER
3.- After a minute the kernel reports:
[ 71.666761] usb 5-1: USB disconnect, device number 2
It has been checked that, although the LED is off, VBUS is present.
Applying the full patch makes it work.
It has only been tested in host mode.
Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
index 04623e52ac5d..72000a7b666f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
@@ -112,6 +112,7 @@
pinctrl-names = "default";
pinctrl-0 = <&vcc5v0_typec0_en>;
regulator-name = "vcc5v0_typec0";
+ regulator-always-on;
vin-supply = <&vcc_sys>;
};
@@ -565,12 +566,11 @@
status = "okay";
u2phy0_otg: otg-port {
- phy-supply = <&vcc5v0_typec0>;
status = "okay";
};
u2phy0_host: host-port {
- phy-supply = <&vcc5v0_host>;
+ phy-supply = <&vcc5v0_typec0>;
status = "okay";
};
};
@@ -620,7 +620,7 @@
&usbdrd_dwc3_0 {
status = "okay";
- dr_mode = "otg";
+ dr_mode = "host";
};
&usbdrd3_1 {
--
2.21.0
next prev parent reply other threads:[~2019-05-22 15:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 21:58 USB3 regression in RK3399 Vicente Bergas
[not found] ` <CAAMcf8B5zpgbTsCu9t0rs9+jWkwRdO2C+KbF+NOt3ZTQx36aZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-21 22:17 ` Heiko Stuebner
2018-02-21 23:04 ` Vicente Bergas
[not found] ` <CAAMcf8B5ffH-5Q3+PcjWwu5UeDk4ESZR0BNczaED+vnPLwge0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-22 9:10 ` Enric Balletbo i Serra
[not found] ` <c8e1bd5a-19ff-9d1c-7e78-b7e605fd1e6b-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2018-02-22 20:30 ` Vicente Bergas
[not found] ` <CAAMcf8C7Px_mC=dex3TqejBNYYUyJxrZHa1c7CbKXj6g==Cbyg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-25 10:03 ` Vicente Bergas
[not found] ` <CAAMcf8DX4Mjuubnvwz9paMJ9oDYaNX-EKwFpsP9a-RfhHgO5Hg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-26 12:26 ` Enric Balletbo i Serra
2018-02-26 16:34 ` Enric Balletbo i Serra
[not found] ` <9e64e878-07c8-912c-c597-7da7b3f96dd6-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2018-02-26 18:38 ` Vicente Bergas
2018-09-08 19:00 ` [PATCH 0/4] arm64: dts: Sapphire board: miscelaneous fixes Vicente Bergas
[not found] ` <20180908190048.14231-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-08 19:00 ` [PATCH 1/4] arm64: dts: Sapphire board: re-order vcc_sys Vicente Bergas
[not found] ` <20180908190048.14231-2-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-10 12:15 ` Heiko Stuebner
2018-09-08 19:00 ` [PATCH 2/4] arm64: dts: Sapphire board: Fix VCC5V0_HOST_EN Vicente Bergas
[not found] ` <20180908190048.14231-3-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-10 12:16 ` Heiko Stuebner
2018-09-08 19:00 ` [PATCH 3/4] arm64: dts: Sapphire board has DVS2 disabled Vicente Bergas
[not found] ` <20180908190048.14231-4-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-10 12:17 ` Heiko Stuebner
2018-09-08 19:00 ` [PATCH 4/4] arm64: dts: Sapphire board: Fix Type-C port supply Vicente Bergas
[not found] ` <20180908190048.14231-5-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-10 12:23 ` Heiko Stuebner
2018-09-10 13:39 ` Vicente Bergas
[not found] ` <CAAMcf8Dr6Kfgx6aqy0vk9TBjW1=0sDp=zJAetjAt5AhPVwHDdA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-09-10 14:10 ` Heiko Stuebner
2018-09-10 16:10 ` [PATCH v2] arm64: dts: rockchip: Fix Type-C port supply in Sapphire board Vicente Bergas
[not found] ` <20180910161029.1948-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-10 17:19 ` Heiko Stuebner
2019-05-18 12:29 ` Vicente Bergas
[not found] ` <574f2bae-0121-4cc7-ad9a-5ba32315d71b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-05-22 15:07 ` Vicente Bergas [this message]
[not found] ` <20190522150717.1748-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-14 9:47 ` [PATCH] arm64: rockchip: dts: sapphire: Fix USB3 Type-C Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522150717.1748-1-vicencb@gmail.com \
--to=vicencb-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.