Re: [PATCH 3/4] gentree.py: add SmPL patch equivalence proof support

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2015-06-08 at 13:08 -0700, Luis R. Rodriguez wrote:

> > Speaking of which - are you aware that pycocci fails (or rather doesn't
> > fail!) miserably when cocci isn't installed/in the $PATH? At least I got
> > a report to that extent,
> 
> Did you verify it?

No, sorry. It was actually a pretty old discussion that came to my mind
now.

> mcgrof@ergon ~/linux-next (git::20150604-proto_ops-send-rcv-smpl)$ which pycocci
> which: no pycocci in
> (/usr/local/bin/:/usr/local/sbin/:/sbin/:/usr/sbin/:/home/mcgrof/bin/:/usr/bin:/usr/local/bin/:/usr/local/sbin/:/sbin/:/usr/sbin/:/home/mcgrof/bin/:/usr/bin:/usr/local/bin/:/usr/local/sbin/:/sbin/:/usr/sbin/:/home/mcgrof/bin/:/usr/bin:/home/mcgrof/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/games)
> 
> So not on my path.

Ah, no, I meant if *spatch* isn't on the $PATH, but you call pycocci ...
the report said that in that case pycocci wasn't really failing
"gracefully".

Anyway - I really should verify that myself first.

> Also Johannes, I value your time and I feel you're
> investing quite a bit of time into this NACK discussion, I obviously
> trust your judgement completely on gentree.py maintenance so for your
> convenience feel free to be concise in your NACK's for patches there.

Nah, don't worry -- I need to write it down to actually have a coherent
argument myself :)

johannes