* [PATCH] rangeset: "has" and "is" functions return boolean
@ 2015-06-09 8:47 Jan Beulich
2015-06-09 8:57 ` Dario Faggioli
2015-06-09 9:00 ` Ian Campbell
0 siblings, 2 replies; 4+ messages in thread
From: Jan Beulich @ 2015-06-09 8:47 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Campbell, Keir Fraser, Ian Jackson, Tim Deegan
[-- Attachment #1: Type: text/plain, Size: 2754 bytes --]
Additionally rangeset_is_empty()'s sole parameter can be const.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/common/rangeset.c
+++ b/xen/common/rangeset.c
@@ -248,11 +248,11 @@ int rangeset_remove_range(
return rc;
}
-int rangeset_contains_range(
+bool_t rangeset_contains_range(
struct rangeset *r, unsigned long s, unsigned long e)
{
struct range *x;
- int contains;
+ bool_t contains;
ASSERT(s <= e);
@@ -264,11 +264,11 @@ int rangeset_contains_range(
return contains;
}
-int rangeset_overlaps_range(
+bool_t rangeset_overlaps_range(
struct rangeset *r, unsigned long s, unsigned long e)
{
struct range *x;
- int overlaps;
+ bool_t overlaps;
ASSERT(s <= e);
@@ -310,14 +310,14 @@ int rangeset_remove_singleton(
return rangeset_remove_range(r, s, s);
}
-int rangeset_contains_singleton(
+bool_t rangeset_contains_singleton(
struct rangeset *r, unsigned long s)
{
return rangeset_contains_range(r, s, s);
}
-int rangeset_is_empty(
- struct rangeset *r)
+bool_t rangeset_is_empty(
+ const struct rangeset *r)
{
return ((r == NULL) || list_empty(&r->range_list));
}
--- a/xen/include/xen/rangeset.h
+++ b/xen/include/xen/rangeset.h
@@ -10,6 +10,8 @@
#ifndef __XEN_RANGESET_H__
#define __XEN_RANGESET_H__
+#include <xen/types.h>
+
struct domain;
struct rangeset;
@@ -50,17 +52,17 @@ void rangeset_limit(
#define _RANGESETF_prettyprint_hex 0
#define RANGESETF_prettyprint_hex (1U << _RANGESETF_prettyprint_hex)
-int __must_check rangeset_is_empty(
- struct rangeset *r);
+bool_t __must_check rangeset_is_empty(
+ const struct rangeset *r);
/* Add/remove/query a numeric range. */
int __must_check rangeset_add_range(
struct rangeset *r, unsigned long s, unsigned long e);
int __must_check rangeset_remove_range(
struct rangeset *r, unsigned long s, unsigned long e);
-int __must_check rangeset_contains_range(
+bool_t __must_check rangeset_contains_range(
struct rangeset *r, unsigned long s, unsigned long e);
-int __must_check rangeset_overlaps_range(
+bool_t __must_check rangeset_overlaps_range(
struct rangeset *r, unsigned long s, unsigned long e);
int rangeset_report_ranges(
struct rangeset *r, unsigned long s, unsigned long e,
@@ -71,7 +73,7 @@ int __must_check rangeset_add_singleton(
struct rangeset *r, unsigned long s);
int __must_check rangeset_remove_singleton(
struct rangeset *r, unsigned long s);
-int __must_check rangeset_contains_singleton(
+bool_t __must_check rangeset_contains_singleton(
struct rangeset *r, unsigned long s);
/* swap contents */
[-- Attachment #2: rangeset-contains-bool.patch --]
[-- Type: text/plain, Size: 2801 bytes --]
rangeset: "has" and "is" functions return boolean
Additionally rangeset_is_empty()'s sole parameter can be const.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/common/rangeset.c
+++ b/xen/common/rangeset.c
@@ -248,11 +248,11 @@ int rangeset_remove_range(
return rc;
}
-int rangeset_contains_range(
+bool_t rangeset_contains_range(
struct rangeset *r, unsigned long s, unsigned long e)
{
struct range *x;
- int contains;
+ bool_t contains;
ASSERT(s <= e);
@@ -264,11 +264,11 @@ int rangeset_contains_range(
return contains;
}
-int rangeset_overlaps_range(
+bool_t rangeset_overlaps_range(
struct rangeset *r, unsigned long s, unsigned long e)
{
struct range *x;
- int overlaps;
+ bool_t overlaps;
ASSERT(s <= e);
@@ -310,14 +310,14 @@ int rangeset_remove_singleton(
return rangeset_remove_range(r, s, s);
}
-int rangeset_contains_singleton(
+bool_t rangeset_contains_singleton(
struct rangeset *r, unsigned long s)
{
return rangeset_contains_range(r, s, s);
}
-int rangeset_is_empty(
- struct rangeset *r)
+bool_t rangeset_is_empty(
+ const struct rangeset *r)
{
return ((r == NULL) || list_empty(&r->range_list));
}
--- a/xen/include/xen/rangeset.h
+++ b/xen/include/xen/rangeset.h
@@ -10,6 +10,8 @@
#ifndef __XEN_RANGESET_H__
#define __XEN_RANGESET_H__
+#include <xen/types.h>
+
struct domain;
struct rangeset;
@@ -50,17 +52,17 @@ void rangeset_limit(
#define _RANGESETF_prettyprint_hex 0
#define RANGESETF_prettyprint_hex (1U << _RANGESETF_prettyprint_hex)
-int __must_check rangeset_is_empty(
- struct rangeset *r);
+bool_t __must_check rangeset_is_empty(
+ const struct rangeset *r);
/* Add/remove/query a numeric range. */
int __must_check rangeset_add_range(
struct rangeset *r, unsigned long s, unsigned long e);
int __must_check rangeset_remove_range(
struct rangeset *r, unsigned long s, unsigned long e);
-int __must_check rangeset_contains_range(
+bool_t __must_check rangeset_contains_range(
struct rangeset *r, unsigned long s, unsigned long e);
-int __must_check rangeset_overlaps_range(
+bool_t __must_check rangeset_overlaps_range(
struct rangeset *r, unsigned long s, unsigned long e);
int rangeset_report_ranges(
struct rangeset *r, unsigned long s, unsigned long e,
@@ -71,7 +73,7 @@ int __must_check rangeset_add_singleton(
struct rangeset *r, unsigned long s);
int __must_check rangeset_remove_singleton(
struct rangeset *r, unsigned long s);
-int __must_check rangeset_contains_singleton(
+bool_t __must_check rangeset_contains_singleton(
struct rangeset *r, unsigned long s);
/* swap contents */
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] rangeset: "has" and "is" functions return boolean
2015-06-09 8:47 [PATCH] rangeset: "has" and "is" functions return boolean Jan Beulich
@ 2015-06-09 8:57 ` Dario Faggioli
2015-06-09 9:00 ` Ian Campbell
1 sibling, 0 replies; 4+ messages in thread
From: Dario Faggioli @ 2015-06-09 8:57 UTC (permalink / raw)
To: Jan Beulich; +Cc: Ian Campbell, xen-devel, Keir Fraser, Ian Jackson, Tim Deegan
[-- Attachment #1.1: Type: text/plain, Size: 518 bytes --]
On Tue, 2015-06-09 at 09:47 +0100, Jan Beulich wrote:
> Additionally rangeset_is_empty()'s sole parameter can be const.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rangeset: "has" and "is" functions return boolean
2015-06-09 8:47 [PATCH] rangeset: "has" and "is" functions return boolean Jan Beulich
2015-06-09 8:57 ` Dario Faggioli
@ 2015-06-09 9:00 ` Ian Campbell
2015-06-09 9:15 ` Jan Beulich
1 sibling, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2015-06-09 9:00 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Keir Fraser, Ian Jackson, Tim Deegan
On Tue, 2015-06-09 at 09:47 +0100, Jan Beulich wrote:
> Additionally rangeset_is_empty()'s sole parameter can be const.
Isn't that true of all/most of the others touched here too? (Once the
underlying range_* list manipulations are made const correct).
If you do decide to go further then there is a "implemnetation" typo in
there too.
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
So far as it goes:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> --- a/xen/common/rangeset.c
> +++ b/xen/common/rangeset.c
> @@ -248,11 +248,11 @@ int rangeset_remove_range(
> return rc;
> }
>
> -int rangeset_contains_range(
> +bool_t rangeset_contains_range(
> struct rangeset *r, unsigned long s, unsigned long e)
> {
> struct range *x;
> - int contains;
> + bool_t contains;
>
> ASSERT(s <= e);
>
> @@ -264,11 +264,11 @@ int rangeset_contains_range(
> return contains;
> }
>
> -int rangeset_overlaps_range(
> +bool_t rangeset_overlaps_range(
> struct rangeset *r, unsigned long s, unsigned long e)
> {
> struct range *x;
> - int overlaps;
> + bool_t overlaps;
>
> ASSERT(s <= e);
>
> @@ -310,14 +310,14 @@ int rangeset_remove_singleton(
> return rangeset_remove_range(r, s, s);
> }
>
> -int rangeset_contains_singleton(
> +bool_t rangeset_contains_singleton(
> struct rangeset *r, unsigned long s)
> {
> return rangeset_contains_range(r, s, s);
> }
>
> -int rangeset_is_empty(
> - struct rangeset *r)
> +bool_t rangeset_is_empty(
> + const struct rangeset *r)
> {
> return ((r == NULL) || list_empty(&r->range_list));
> }
> --- a/xen/include/xen/rangeset.h
> +++ b/xen/include/xen/rangeset.h
> @@ -10,6 +10,8 @@
> #ifndef __XEN_RANGESET_H__
> #define __XEN_RANGESET_H__
>
> +#include <xen/types.h>
> +
> struct domain;
> struct rangeset;
>
> @@ -50,17 +52,17 @@ void rangeset_limit(
> #define _RANGESETF_prettyprint_hex 0
> #define RANGESETF_prettyprint_hex (1U << _RANGESETF_prettyprint_hex)
>
> -int __must_check rangeset_is_empty(
> - struct rangeset *r);
> +bool_t __must_check rangeset_is_empty(
> + const struct rangeset *r);
>
> /* Add/remove/query a numeric range. */
> int __must_check rangeset_add_range(
> struct rangeset *r, unsigned long s, unsigned long e);
> int __must_check rangeset_remove_range(
> struct rangeset *r, unsigned long s, unsigned long e);
> -int __must_check rangeset_contains_range(
> +bool_t __must_check rangeset_contains_range(
> struct rangeset *r, unsigned long s, unsigned long e);
> -int __must_check rangeset_overlaps_range(
> +bool_t __must_check rangeset_overlaps_range(
> struct rangeset *r, unsigned long s, unsigned long e);
> int rangeset_report_ranges(
> struct rangeset *r, unsigned long s, unsigned long e,
> @@ -71,7 +73,7 @@ int __must_check rangeset_add_singleton(
> struct rangeset *r, unsigned long s);
> int __must_check rangeset_remove_singleton(
> struct rangeset *r, unsigned long s);
> -int __must_check rangeset_contains_singleton(
> +bool_t __must_check rangeset_contains_singleton(
> struct rangeset *r, unsigned long s);
>
> /* swap contents */
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] rangeset: "has" and "is" functions return boolean
2015-06-09 9:00 ` Ian Campbell
@ 2015-06-09 9:15 ` Jan Beulich
0 siblings, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2015-06-09 9:15 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, Keir Fraser, Ian Jackson, Tim Deegan
>>> On 09.06.15 at 11:00, <ian.campbell@citrix.com> wrote:
> On Tue, 2015-06-09 at 09:47 +0100, Jan Beulich wrote:
>> Additionally rangeset_is_empty()'s sole parameter can be const.
>
> Isn't that true of all/most of the others touched here too? (Once the
> underlying range_* list manipulations are made const correct).
No, the others are taking locks.
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-09 9:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-09 8:47 [PATCH] rangeset: "has" and "is" functions return boolean Jan Beulich
2015-06-09 8:57 ` Dario Faggioli
2015-06-09 9:00 ` Ian Campbell
2015-06-09 9:15 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.