All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Irina Tirdea <irina.tirdea@intel.com>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: goodix - do not explicitly set evbits in input device
Date: Wed, 10 Jun 2015 12:18:10 +0200	[thread overview]
Message-ID: <1433931490.5707.18.camel@hadess.net> (raw)
In-Reply-To: <20150609185219.GA33366@dtor-ws>

On Tue, 2015-06-09 at 11:52 -0700, Dmitry Torokhov wrote:
> input_mt_init_slots() will do that for us.

I'm guessing you know what you're doing here, but I couldn't find where
the EV_SYN bit would have been set in the input_mt_init_slots() call
chain.

> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/input/touchscreen/goodix.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/goodix.c 
> b/drivers/input/touchscreen/goodix.c
> index 73ade35..b4d12e2 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -301,10 +301,6 @@ static int goodix_request_input_dev(struct 
> goodix_ts_data *ts, u16 version,
>               return -ENOMEM;
>       }
>  
> -     ts->input_dev->evbit[0] = BIT_MASK(EV_SYN) |
> -                               BIT_MASK(EV_KEY) |
> -                               BIT_MASK(EV_ABS);
> -
>       input_set_abs_params(ts->input_dev, ABS_MT_POSITION_X,
>                            0, ts->abs_x_max, 0, 0);
>       input_set_abs_params(ts->input_dev, ABS_MT_POSITION_Y,
> -- 
> 2.2.0.rc0.207.ga3a616c
> 
> 

  reply	other threads:[~2015-06-10 10:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09 18:52 [PATCH] Input: goodix - do not explicitly set evbits in input device Dmitry Torokhov
2015-06-10 10:18 ` Bastien Nocera [this message]
2015-06-10 14:39   ` Benjamin Tissoires
2015-06-10 15:08     ` Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433931490.5707.18.camel@hadess.net \
    --to=hadess@hadess.net \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=irina.tirdea@intel.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.