From: Bastien Nocera <hadess@hadess.net>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Irina Tirdea <irina.tirdea@intel.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: goodix - do not explicitly set evbits in input device
Date: Wed, 10 Jun 2015 17:08:39 +0200 [thread overview]
Message-ID: <1433948919.5707.19.camel@hadess.net> (raw)
In-Reply-To: <20150610143910.GB27326@mail.corp.redhat.com>
On Wed, 2015-06-10 at 10:39 -0400, Benjamin Tissoires wrote:
> On Jun 10 2015 or thereabouts, Bastien Nocera wrote:
> > On Tue, 2015-06-09 at 11:52 -0700, Dmitry Torokhov wrote:
> > > input_mt_init_slots() will do that for us.
> >
> > I'm guessing you know what you're doing here, but I couldn't find
> > where
> > the EV_SYN bit would have been set in the input_mt_init_slots()
> > call
> > chain.
>
> input_register_device() sets EV_SYN bit for us (it is a mandatory
> field
> for input).
<snip>
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
OK, thanks for the explanation.
Acked-by: Bastien Nocera <hadess@hadess.net>
prev parent reply other threads:[~2015-06-10 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 18:52 [PATCH] Input: goodix - do not explicitly set evbits in input device Dmitry Torokhov
2015-06-10 10:18 ` Bastien Nocera
2015-06-10 14:39 ` Benjamin Tissoires
2015-06-10 15:08 ` Bastien Nocera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433948919.5707.19.camel@hadess.net \
--to=hadess@hadess.net \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=irina.tirdea@intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.