From: Gerd Hoffmann <kraxel@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/virtio: checking for NULL instead of IS_ERR
Date: Thu, 11 Jun 2015 06:16:59 +0000 [thread overview]
Message-ID: <1434003419.27114.0.camel@redhat.com> (raw)
In-Reply-To: <20150610192710.GA10145@mwanda>
On Mi, 2015-06-10 at 22:27 +0300, Dan Carpenter wrote:
> virtio_gpu_alloc_object() returns an error pointer, it never returns
> NULL.
>
> Fixes: dc5698e80cf7 ('Add virtio gpu driver.')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/virtio: checking for NULL instead of IS_ERR
Date: Thu, 11 Jun 2015 08:16:59 +0200 [thread overview]
Message-ID: <1434003419.27114.0.camel@redhat.com> (raw)
In-Reply-To: <20150610192710.GA10145@mwanda>
On Mi, 2015-06-10 at 22:27 +0300, Dan Carpenter wrote:
> virtio_gpu_alloc_object() returns an error pointer, it never returns
> NULL.
>
> Fixes: dc5698e80cf7 ('Add virtio gpu driver.')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
next prev parent reply other threads:[~2015-06-11 6:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 19:27 [patch] drm/virtio: checking for NULL instead of IS_ERR Dan Carpenter
2015-06-10 19:27 ` Dan Carpenter
2015-06-11 6:16 ` Gerd Hoffmann
2015-06-11 6:16 ` Gerd Hoffmann [this message]
2015-06-11 6:16 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2015-06-10 19:27 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434003419.27114.0.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.