From: Johannes Berg <johannes@sipsolutions.net>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFC] ath9k: advertise p2p dev support when chanctx
Date: Tue, 16 Jun 2015 09:08:40 +0200 [thread overview]
Message-ID: <1434438520.2337.7.camel@sipsolutions.net> (raw)
In-Reply-To: <CALhHN=rEf0cR211Vizkb2xcbxSseda_6w1Uibs3DVD0GSXAq2w@mail.gmail.com> (sfid-20150616_083056_853720_6BA9919F)
On Tue, 2015-06-16 at 08:30 +0200, Janusz Dziedzic wrote:
> Other fix I can image is change wpa_supplicant and add
> NL80211_SCAN_FLAG_AP to p2p_find, and set in ath9k driver
> wiphy->features |= NL80211_FEATURE_AP_SCAN;
>
> NL80211_FEATURE_AP_SCAN is not set when use_chanctx=1
>
> I am not sure which is better. First one required only fix in ath9k,
> second one also required changes in wpa_supplicant.
It would be unfortunate if a driver change required wpa_s changes. It
doesn't seem so bad to add p2p-device support to the driver, after all,
there isn't much it needs to do for that.
This seems like a strange quirk though - you can normally not do any p2p
operation when already operating as soft-AP (without P2P-device), no?
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: Sujith Manoharan <sujith@msujith.org>,
Arend van Spriel <arend@broadcom.com>,
linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net,
Felix Fietkau <nbd@openwrt.org>, Jouni Malinen <j@w1.fi>
Subject: Re: [RFC] ath9k: advertise p2p dev support when chanctx
Date: Tue, 16 Jun 2015 09:08:40 +0200 [thread overview]
Message-ID: <1434438520.2337.7.camel@sipsolutions.net> (raw)
In-Reply-To: <CALhHN=rEf0cR211Vizkb2xcbxSseda_6w1Uibs3DVD0GSXAq2w@mail.gmail.com> (sfid-20150616_083056_853720_6BA9919F)
On Tue, 2015-06-16 at 08:30 +0200, Janusz Dziedzic wrote:
> Other fix I can image is change wpa_supplicant and add
> NL80211_SCAN_FLAG_AP to p2p_find, and set in ath9k driver
> wiphy->features |= NL80211_FEATURE_AP_SCAN;
>
> NL80211_FEATURE_AP_SCAN is not set when use_chanctx=1
>
> I am not sure which is better. First one required only fix in ath9k,
> second one also required changes in wpa_supplicant.
It would be unfortunate if a driver change required wpa_s changes. It
doesn't seem so bad to add p2p-device support to the driver, after all,
there isn't much it needs to do for that.
This seems like a strange quirk though - you can normally not do any p2p
operation when already operating as soft-AP (without P2P-device), no?
johannes
next prev parent reply other threads:[~2015-06-16 7:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 5:10 [ath9k-devel] [RFC] ath9k: advertise p2p dev support when chanctx Janusz Dziedzic
2015-06-10 5:10 ` Janusz Dziedzic
2015-06-15 10:33 ` [ath9k-devel] " Sujith Manoharan
2015-06-15 10:33 ` Sujith Manoharan
2015-06-15 11:38 ` [ath9k-devel] " Janusz Dziedzic
2015-06-15 11:38 ` Janusz Dziedzic
2015-06-15 11:46 ` [ath9k-devel] " Janusz Dziedzic
2015-06-15 11:46 ` Janusz Dziedzic
2015-06-15 15:47 ` [ath9k-devel] " Sujith Manoharan
2015-06-15 15:47 ` Sujith Manoharan
2015-06-15 18:19 ` [ath9k-devel] " Arend van Spriel
2015-06-15 18:19 ` Arend van Spriel
2015-06-16 1:25 ` [ath9k-devel] " Sujith Manoharan
2015-06-16 1:25 ` Sujith Manoharan
2015-06-16 6:30 ` [ath9k-devel] " Janusz Dziedzic
2015-06-16 6:30 ` Janusz Dziedzic
2015-06-16 7:08 ` Johannes Berg [this message]
2015-06-16 7:08 ` Johannes Berg
2015-06-16 7:53 ` Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434438520.2337.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.