From: Ian Campbell <ian.campbell@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v6 1/8] xenalyze: add to tools/xentrace/
Date: Tue, 16 Jun 2015 11:24:39 +0100 [thread overview]
Message-ID: <1434450279.13744.88.camel@citrix.com> (raw)
In-Reply-To: <1434040245-22195-2-git-send-email-olaf@aepfle.de>
On Thu, 2015-06-11 at 16:30 +0000, Olaf Hering wrote:
> @@ -26,6 +28,7 @@ install: build
> [ -z "$(LIBBIN)" ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> $(INSTALL_DIR) $(DESTDIR)$(MAN1DIR)
> $(INSTALL_DIR) $(DESTDIR)$(MAN8DIR)
> + $(INSTALL_PROG) $(BIN) $(DESTDIR)$(bindir)
Building on !x86 fails here because $(BIN) is empty:
install: missing destination file operand after `/local/scratch/ianc/devel/committer-arm32.git/dist/install/usr/local/bin'
Try `install --help' for more information.
I propose to continue trying to commit with this fixup patch folded in:
diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
index 8932b73..3676812 100644
--- a/tools/xentrace/Makefile
+++ b/tools/xentrace/Makefile
@@ -28,7 +28,9 @@ install: build
[ -z "$(LIBBIN)" ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
$(INSTALL_DIR) $(DESTDIR)$(MAN1DIR)
$(INSTALL_DIR) $(DESTDIR)$(MAN8DIR)
+ifneq ($(BIN),)
$(INSTALL_PROG) $(BIN) $(DESTDIR)$(bindir)
+endif
$(INSTALL_PROG) $(SBIN) $(DESTDIR)$(sbindir)
$(INSTALL_PYTHON_PROG) $(SCRIPTS) $(DESTDIR)$(bindir)
[ -z "$(LIBBIN)" ] || $(INSTALL_PROG) $(LIBBIN) $(DESTDIR)$(LIBEXEC_BIN)
next prev parent reply other threads:[~2015-06-16 10:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 16:30 [PATCH v6 0/8] add xenalyze to staging Olaf Hering
2015-06-11 16:30 ` [PATCH v6 1/8] xenalyze: add to tools/xentrace/ Olaf Hering
2015-06-16 10:24 ` Ian Campbell [this message]
2015-06-16 10:34 ` George Dunlap
2015-06-16 10:35 ` Ian Campbell
2015-06-11 16:30 ` [PATCH v6 2/8] xenalyze: print newline after unknown hvm events Olaf Hering
2015-06-11 16:30 ` [PATCH v6 3/8] xenalyze: include odd mmio states in default output Olaf Hering
2015-06-11 16:30 ` [PATCH v6 4/8] xenalyze: handle TRC_TRACE_WRAP_BUFFER Olaf Hering
2015-06-11 16:30 ` [PATCH v6 5/8] xenalyze: handle more events in sched_process Olaf Hering
2015-06-12 16:48 ` Wei Liu
2015-06-12 16:58 ` Olaf Hering
2015-06-12 17:08 ` Wei Liu
2015-06-11 16:30 ` [PATCH v6 6/8] xenalyze: remove trailing whitespaces Olaf Hering
2015-06-11 16:30 ` [PATCH v6 7/8] xenalyze: remove argp_program_version Olaf Hering
2015-06-11 16:30 ` [PATCH v6 8/8] xenalyze: remove unused private cpumask_t Olaf Hering
2015-06-12 16:49 ` Wei Liu
2015-06-16 11:43 ` [PATCH v6 0/8] add xenalyze to staging Ian Campbell
2015-06-16 15:56 ` Olaf Hering
2015-06-17 9:03 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434450279.13744.88.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.