Re: [OSSTEST Nested PATCH v11 6/7] Compose the main recipe of nested test job

[Ian Campbell <ian.campbell@citrix.com>]

On Thu, 2015-06-18 at 09:16 +0000, Pang, LongtaoX wrote:
> 
> > -----Original Message-----
> > From: Ian Campbell [mailto:ian.campbell@citrix.com]
> > Sent: Wednesday, June 17, 2015 7:49 PM
> > To: Pang, LongtaoX
> > Cc: Hu, Robert; Ian Jackson; xen-devel@lists.xen.org; wei.liu2@citrix.com
> > Subject: Re: [OSSTEST Nested PATCH v11 6/7] Compose the main recipe of nested
> > test job
> > 
> > On Wed, 2015-06-17 at 11:00 +0000, Pang, LongtaoX wrote:
> > > > > 2015-06-17 08:10:26 Z executing ssh ... root@192.168.199.25 find /tmp
> > /var/run
> > > > /var/tmp /var/lib/xen /var/core ! -type d -print0 -ls -printf '\0'
> > > > > find: `/var/core': No such file or directory
> > > >
> > > > /var/core is created by ts-host-install. I think the tail end of the
> > > > function sub in there which does that and populates /etc/sysctl.conf
> > > > and /etc/security/limits.d/coredumps.conf should be refactored probably
> > > > to be alongside the osstest-confirm-booted thing which IIRC you are
> > > > already going to refactor in the next version.
> > > >
> > > I reviewed related code in 'ts-host-install'. But I am not very clear, the below
> > code will be executed
> > > in 'ts-debian-hvm-install' too? Or refactor 'osstest-confirm-booted' and the
> > below action should be finished inside this shell script?
> > > Since, it need '/var/core' directory in L1, please correct me.
> > 
> > I think you've already arranged for the osstest-confirm-booted stuff to
> > happen for the L1 host too, but that Ian J has requested it be done
> > differently such that it is not duplicated in two places.
> > 
> Yes, I have arranged for osstest-confirm-booted stuff to happen for the L1 host via call
> function in 'ts-nested-setup' script. So, the setup of /var/core and the associated sysctl.conf 
> and limits.d changes should be done in 'ts-nested-setup' too? Or be done in 
> 'ts-debian-hvm-install' script? Which do you prefer? I prefer to 'ts-nested-setup'.

Ian has already indicated in
<21880.17044.20906.699699@mariner.uk.xensource.com> that the
osstest-confirm-booted stuff should be broken out and not duplicated
into ts-nested-setup. Once you have followed that request then you will
also have an ideal place to do the core dump setup too.

Ian.